## Summary Brings the non-mixin Java sources from `main` onto the 1.20.1 backport line, using Epic 2's NBT layer (`ShuffleBlockList.read` / `set`) and Forge 1.20.1 APIs in place of NeoForge's data components, payload codecs, and menu-type extension. Closes Epic 3 in the Forge 1.20.1 backport plan (#6). **Base branch:** `1.20.1-backport` **Target branch:** `feat/forge-1.20.1-items-menus-network` ## Changes ### Items (`item/`) - **`BaseShuffleFilterItem`** — extends Create's `FilterItem`; reads configuration via `ShuffleBlockList.read(stack)`; `appendHoverText` uses the 1.20.1 signature (`@Nullable Level, List<Component>, TooltipFlag`). The `getComponentType()` override is dropped — there is no `DataComponentType` on 1.20.1. - **`ShuffleFilterItem` / `WeightedShuffleFilterItem`** — same shape as `main`; weighted version retains its own `appendHoverText` to render percentages. Right-click opens the menu via `NetworkHooks.openScreen(player, provider, bufWriter)` (Forge 1.20.1's `ServerPlayer.openMenu` has no buf-consumer overload). - **`ShuffleFilterItemStack`** — `ItemStack.isSameItemSameComponents` → `isSameItemSameTags` (1.20.1 equivalent). Cascading logic is otherwise unchanged. ### Menus (`menu/`) - **`ModMenuTypes`** — `DeferredRegister<MenuType<?>>` against `ForgeRegistries.MENU_TYPES`; uses `IForgeMenuType.create((id, inv, data) -> …)` for client-side instantiation from the buf written by the item's `use` call. - **`ShuffleFilterMenu` / `WeightedShuffleFilterMenu`** — `getBlockList()` swapped to `ShuffleBlockList.read(getFilterStack())`. Slot layout untouched. ### Networking (`network/`) - **`FilterConfigPacket`** — rebuilt as a plain class with `encode(pkt, buf)` / `decode(buf)` / `handle(pkt, ctxSup)`. **The `mode` field is dropped** — the server derives weighted vs. equal from `filterStack.getItem() instanceof WeightedShuffleFilterItem`, matching the NeoForge handler's logic. Wire payload otherwise unchanged: `filterSlot` (varInt), `items` (collection of `ItemStack`), `weights` (collection of float). - **`ModPackets`** — single `SimpleChannel` named `createshufflefilter:main`, protocol version `"1"`; `FilterConfigPacket` registered as `PLAY_TO_SERVER`. ### Utilities (`util/`) - **`ShuffleFilterUtil`** — same cascading / fallback logic; recursion uses `ShuffleBlockList.read(configuredStack)`; uses Forge `net.minecraftforge.items.IItemHandler`. - **`FilterModeHelper`** — `getBlockList(stack)` goes through `ShuffleBlockList.read(stack)`. ### Entrypoint - **`CreateShuffleFilter`** — switched to `@Mod(MODID)` with a no-arg constructor that pulls the mod event bus via `FMLJavaModLoadingContext.get().getModEventBus()`. Registers `CreateRegistrate` (Shuffle Filter + Weighted Shuffle Filter — no `.component(...)` because data components don't exist on 1.20.1; an unconfigured stack has no NBT tag and `ShuffleBlockList.read(stack)` returns `EMPTY`), registers `ModMenuTypes.MENUS`, and calls `ModPackets.register()` from the constructor so the channel is ready before any world loads. ## Design decisions - **Where `ShuffleMode` was deleted in Epic 2, the wire format follows.** `FilterConfigPacket` no longer carries `mode` — the server decides based on the filter item's class. No migration path is needed because the 1.20.1 backport has not had a prior release. - **`Screen.hasShiftDown()` for tooltip detail toggle.** `TooltipFlag.hasShiftDown()` is a NeoForge addition, so the items reach into the client-only `Screen` class. `appendHoverText` is only invoked on the client in 1.20.1 (the call-site `ItemStack#getTooltipLines` is client-only), so the reference is safe at runtime on a dedicated server. - **`NetworkHooks.openScreen` over `ServerPlayer.openMenu`** — only `NetworkHooks.openScreen(player, MenuProvider, Consumer<FriendlyByteBuf>)` carries the slot int from the server menu opener to the client `IForgeMenuType` factory on Forge 1.20.1. ## Test plan - [ ] `./gradlew build` → Expected: compiles green, no `ModDataComponents` / `CustomPacketPayload` / `StreamCodec` / `IMenuTypeExtension` imports survive (verified in CI) - [ ] `./gradlew runClient` and join a world → Expected: client launches; both filters show up under the Create creative tab and are obtainable via `/give` - [ ] Right-click an unconfigured `ShuffleFilterItem` → Expected: server opens `ShuffleFilterMenu`, the slot int flows through the menu opener buffer, no NPE (screen rendering may be blank until Epic 4 — that is OK) - [ ] Right-click an unconfigured `WeightedShuffleFilterItem` → Expected: opens `WeightedShuffleFilterMenu` analogously - [ ] Send a synthetic `FilterConfigPacket` (debug command / Epic 4 stub) with N blocks → Expected: server applies it; `ShuffleBlockList.read(stack)` afterwards returns the same N entries - [ ] Configure a filter, drop it, pick it up, save+exit, reload → Expected: NBT persists, configuration survives the round-trip - [ ] Configure a filter, place via hopper/chest into another inventory then take out → Expected: replicated NBT matches (verifies `writeItem`/`readItem` carries the tag) - [ ] Shift-hover a configured filter → Expected: tooltip lists the blocks (`appendHoverText` 1.20.1 signature compiles + fires) - [ ] Cascading filter test: configure an equal filter with a weighted filter inside (3 blocks). Run `ShuffleFilterUtil.selectItemCascading` against a dummy inventory → Expected: depth-1 selection returns one of the inner three items ## Dependencies - Epic 2 (#8) — merged to `1.20.1-backport`. Verified: `ShuffleBlockList.read(stack)` / `set(stack, list)` / `writeToBuf` / `readFromBuf` all in place. - Epic 1 (#7) — merged to `1.20.1-backport`. Verified: `legacyForge` block, Create 6.0.8-289, Registrate `MC1.20-1.3.3`, `mods.toml` template. Closes #9 Co-authored-by: Matej Hozlar <hozlarmatej0@gmail.com> Reviewed-on: https://gitea.matejhoz.com/Agent772/Create-ShuffleFilter/pulls/18 Co-authored-by: Claude <matejhozlarzadek8ii@gmail.com> Co-committed-by: Claude <matejhozlarzadek8ii@gmail.com>

Request: Compat with Forge on MC1.20.1 #9

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions