Skip to content

search() passes limit/candidates into SQL with no guard #22

Description

@royalpinto007

Problem

search() passes limit/candidates straight into SQL with no guard. Only the /ask body validates; evaluate.run_case and direct callers do not.

Where

vaultrag/retrieval.py (limit: int = 5, candidates: int = 50, interpolated into LIMIT).

Acceptance

Add a failing test first asserting search() with limit=0/-1 or candidates=-1 raises ValueError before SQL. Then fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions