Services API gbak does not provide support for -SKIP_SCHEMA_DATA/-INCLUDE_SCHEMA_DATA equivalent options

[mrotteveel]

The support for gbak -SKIP_SCHEMA_DATA and -INCLUDE_SCHEMA_DATA is not fully implemented in the Services API.

Attempts to use these options, using isc_spb_bkp_skip_schema_data and isc_spb_bkp_include_schema_data, through the Services API results in error (through Jaybird):

unrecognized service parameter block; All services except for getting server log require switches [SQLState:42000, ISC error code:335544562]

or through fbsvcmgr:

fbsvcmgr localhost user sysdba password masterkey action_backup dbname test.fdb bkp_file /var/lib/firebird/data/test_svc.fbk bkp_include_schema_data PUBLIC verbose

Invalid clumplet buffer structure: unknown parameter for backup/restore (23)

(with bkp_skip_schema_data, the error mentions (22) instead of (23).)

IntlParametersBlock and ClumpletReader are missing entries for isc_spb_bkp_skip_schema_data and isc_spb_bkp_include_schema_data (this is just from a shallow search, I haven't checked in more depth if anything else might be missing).

Using gbak with -se localhost does seem to work.

[asfernandes]

Please test the fix.
There was a missing treatment for isc_spb_bkp_include_data too, so it may had a problem too.

[mrotteveel]

Interesting, isc_spb_bkp_include_data worked already (only checked with Jaybird), so maybe IntlParametersBlock is not involved in that part?

[mrotteveel]

@asfernandes Thanks, I'll check it with the next snapshot.

[aafemt]

Interesting, isc_spb_bkp_include_data worked already (only checked with Jaybird), so maybe IntlParametersBlock is not involved in that part?

Dis you test it with non-ASCII names? Before the commit the content of the clumplet was sent to server as is which makes no difference for ASCII.

[mrotteveel]

@aafemt Client-side test I used was pure Java, no fbclient involved.