The traditionally-called "fullscreen button" in main player, here defined as screenRotationButton, has a rather unintuitive behavior (at least for me). I saw the comment at Player.java:4611 but couldn't understand it. Can you explain its expected behavior and the reasoning behind it?
The reason I am bringing this up is that I suspect there has been a change in the behavior of this button (eventhough I couldn't find any related change in the code recently). When I was watching:
- Landscape video
- Fullscreen in Landscape rotation
- Screen rotation locked
the button used to rotate the screen and exiting the fullscreen mode, showing the comments. Now it only rotates the screen but doesn't exit from fullscreen mode. Also I haven't realized there was different behavior for screen rotation unlocked.
I thought about creating a PR having an (advanced) option for my described behavior with ignoring screen rotation lock, as I think would be a better UX and is the same behavior as the official Youtube client. Before that, I decided it is better to ask you about this.
The traditionally-called "fullscreen button" in main player, here defined as
screenRotationButton, has a rather unintuitive behavior (at least for me). I saw the comment at Player.java:4611 but couldn't understand it. Can you explain its expected behavior and the reasoning behind it?The reason I am bringing this up is that I suspect there has been a change in the behavior of this button (eventhough I couldn't find any related change in the code recently). When I was watching:
the button used to rotate the screen and exiting the fullscreen mode, showing the comments. Now it only rotates the screen but doesn't exit from fullscreen mode. Also I haven't realized there was different behavior for screen rotation unlocked.
I thought about creating a PR having an (advanced) option for my described behavior with ignoring screen rotation lock, as I think would be a better UX and is the same behavior as the official Youtube client. Before that, I decided it is better to ask you about this.