Merge pull request #2353 from IntelPython/remove-deprecated-device-info-query

Remove `sub_group_independent_forward_progress` device info query

Author: ndgrigorian

dpctl/_backend.pxd

@@ -234,9 +234,6 @@ cdef extern from "syclinterface/dpctl_sycl_device_interface.h":
     cdef bool DPCTLDevice_IsAccelerator(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_IsCPU(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_IsGPU(const DPCTLSyclDeviceRef DRef)
-    cdef bool DPCTLDevice_GetSubGroupIndependentForwardProgress(
-        const DPCTLSyclDeviceRef DRef
-    )
     cdef uint32_t DPCTLDevice_GetPreferredVectorWidthChar(
         const DPCTLSyclDeviceRef DRef
     )

dpctl/_sycl_device.pyx

@@ -99,7 +99,6 @@ from ._backend cimport (  # noqa: E211
     DPCTLDevice_GetPreferredVectorWidthShort,
     DPCTLDevice_GetProfilingTimerResolution,
     DPCTLDevice_GetSingleFPConfig,
-    DPCTLDevice_GetSubGroupIndependentForwardProgress,
     DPCTLDevice_GetSubGroupSizes,
     DPCTLDevice_GetVendor,
     DPCTLDevice_GetVendorId,
@@ -1246,20 +1245,6 @@ cdef class SyclDevice(_SyclDevice):
         )
         return max_num_sub_groups
 
-    @property
-    def sub_group_independent_forward_progress(self):
-        """ Returns ``True`` if the device supports independent forward progress
-        of sub-groups with respect to other sub-groups in the same work-group.
-
-        Returns:
-            bool:
-                Indicates if the device supports independent forward progress
-                of sub-groups.
-        """
-        return DPCTLDevice_GetSubGroupIndependentForwardProgress(
-            self._device_ref
-        )
-
     @property
     def sub_group_sizes(self):
         """ Returns tuple of supported sub-group sizes for this device.

dpctl/tests/_device_attributes_checks.py

@@ -322,13 +322,6 @@ def check_image_3d_max_depth(device):
         pytest.fail("image_3d_max_depth call failed")
 
 
-def check_sub_group_independent_forward_progress(device):
-    try:
-        device.sub_group_independent_forward_progress
-    except Exception:
-        pytest.fail("sub_group_independent_forward_progress call failed")
-
-
 def check_preferred_vector_width_char(device):
     try:
         device.preferred_vector_width_char
@@ -812,7 +805,6 @@ def check_partition_affinity_domains(device):
     check_is_accelerator,
     check_is_cpu,
     check_is_gpu,
-    check_sub_group_independent_forward_progress,
     check_preferred_vector_width_char,
     check_preferred_vector_width_short,
     check_preferred_vector_width_int,

libsyclinterface/include/syclinterface/dpctl_sycl_device_interface.h

@@ -458,18 +458,6 @@ DPCTL_API
 __dpctl_give DPCTLDeviceVectorRef DPCTLDevice_CreateSubDevicesByAffinity(
     __dpctl_keep const DPCTLSyclDeviceRef DRef,
     DPCTLPartitionAffinityDomainType PartAffDomTy);
-/*!
- * @brief Wrapper over
- * device.get_info<info::device::sub_group_independent_forward_progress>.
- *
- * @param    DRef           Opaque pointer to a ``sycl::device``
- * @return   Returns true if the device supports independent forward progress of
- * sub-groups with respect to other sub-groups in the same work-group.
- * @ingroup DeviceInterface
- */
-DPCTL_API
-bool DPCTLDevice_GetSubGroupIndependentForwardProgress(
-    __dpctl_keep const DPCTLSyclDeviceRef DRef);
 
 /*!
  * @brief Wrapper over

libsyclinterface/source/dpctl_sycl_device_interface.cpp

@@ -408,22 +408,6 @@ declmethod(GetImage3dMaxHeight, image3d_max_height, size_t);
 declmethod(GetImage3dMaxDepth, image3d_max_depth, size_t);
 #undef declmethod
 
-bool DPCTLDevice_GetSubGroupIndependentForwardProgress(
-    __dpctl_keep const DPCTLSyclDeviceRef DRef)
-{
-    bool SubGroupProgress = false;
-    auto D = unwrap<device>(DRef);
-    if (D) {
-        try {
-            SubGroupProgress = D->get_info<
-                info::device::sub_group_independent_forward_progress>();
-        } catch (std::exception const &e) {
-            error_handler(e, __FILE__, __func__, __LINE__);
-        }
-    }
-    return SubGroupProgress;
-}
-
 namespace
 {
 

libsyclinterface/tests/test_sycl_device_interface.cpp

@@ -233,18 +233,6 @@ TEST_P(TestDPCTLSyclDeviceInterface, ChkIsGPU)
     EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsGPU(DRef));
 }
 
-TEST_P(TestDPCTLSyclDeviceInterface, ChkGetSubGroupIndependentForwardProgress)
-{
-    bool sub_group_progress = 0;
-    EXPECT_NO_FATAL_FAILURE(
-        sub_group_progress =
-            DPCTLDevice_GetSubGroupIndependentForwardProgress(DRef));
-    auto D = reinterpret_cast<device *>(DRef);
-    auto get_sub_group_progress =
-        D->get_info<info::device::sub_group_independent_forward_progress>();
-    EXPECT_TRUE(get_sub_group_progress == sub_group_progress);
-}
-
 TEST_P(TestDPCTLSyclDeviceInterface, ChkGetPreferredVectorWidthChar)
 {
     uint32_t vector_width_char = 0;
@@ -1003,15 +991,6 @@ TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetMaxImageDims)
     ASSERT_TRUE(res == 0);
 }
 
-TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetSubGroupIndependentForwardProgress)
-{
-    bool indep_pr = true;
-    EXPECT_NO_FATAL_FAILURE(
-        indep_pr =
-            DPCTLDevice_GetSubGroupIndependentForwardProgress(Null_DRef));
-    ASSERT_FALSE(indep_pr);
-}
-
 TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetPreferredVectorWidth)
 {
     uint32_t w = -1;