From 9665764bbed85b06fc34673ff52cdc4875118203 Mon Sep 17 00:00:00 2001 From: Christian Jaeger Date: Mon, 24 Aug 2026 15:13:22 +0200 Subject: [PATCH 1/3] ci-make: put all temp files into a single directory This makes it easier to find them all together after a run if needed. --- test/ci-make | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/test/ci-make b/test/ci-make index efe4203..0fa389f 100755 --- a/test/ci-make +++ b/test/ci-make @@ -26,21 +26,25 @@ run() { fi } -tmpfiles=() +tmpdir=$(mktemp -d) +i=0 for target in "${targets[@]}"; do - tmp=$(mktemp) - tmpfiles+=("$tmp") + tmp="$tmpdir/$i" + i=$(( i + 1 )) ( run "$target" 2>&1 | test/target/debug/log-timestamp > "$tmp" ) & done -for target in "${targets[@]}"; do +for _target in "${targets[@]}"; do wait || true done exit_code=0 -for tmp in "${tmpfiles[@]}"; do +i=0 +for _target in "${targets[@]}"; do + tmp="$tmpdir/$i" + i=$(( i + 1 )) echo "========================================================================================" if tail -1 "$tmp" | grep -q ": Ok."; then if [ "${CI_MAKE_VERBOSE-}" == 1 ]; then From 7631c0336e10126ceed2908d929ed594bcf91d20 Mon Sep 17 00:00:00 2001 From: Christian Jaeger Date: Mon, 31 Aug 2026 12:22:35 +0200 Subject: [PATCH 2/3] ci-make: show temp directory path, document intentional leak --- test/ci-make | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/ci-make b/test/ci-make index 0fa389f..a4a1bae 100755 --- a/test/ci-make +++ b/test/ci-make @@ -27,6 +27,8 @@ run() { } tmpdir=$(mktemp -d) +# Leak the files in tmpdir on purpose so that they can be examined. +echo "ci-make writing to $tmpdir" i=0 for target in "${targets[@]}"; do From 8224809a7d0c89f08df54d881d27ec86660ea40d Mon Sep 17 00:00:00 2001 From: Christian Jaeger Date: Mon, 24 Aug 2026 15:16:05 +0200 Subject: [PATCH 3/3] ci-make: avoid treating input as test commands Thanks to shellcheck. (I thought I had checked that in bash a long time ago and it was no problem?) --- test/ci-make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/ci-make b/test/ci-make index a4a1bae..a232172 100755 --- a/test/ci-make +++ b/test/ci-make @@ -10,7 +10,7 @@ usage() { exit 1 } -if [ $# -eq 0 ] || [ "$1" = -h -o "$1" = --help ]; then +if [ $# -eq 0 ] || [ "$1" = -h ] || [ "$1" = --help ]; then usage fi