Skip to content

Unify ICPP and IB Routine/Function Calls #1593

@danieljvickers

Description

@danieljvickers

Originally, IB and ICPP patches existed as a single module, but had to be broken apart to move the IB patch code to simulation. While they must remain two separate files with some distinct features, they still share a significant amount of code. Using overlapping subroutine/function calls as much as possible will limit the amount of code and maintenance required to develop these features moving forward. Thanks to changes made in #1454, #1451, and #1478 , we have made significant steps towards reunifying the ICPP and IB patch frameworks. However, there is more work to be done in terms of code maintenance.

To continue reunifying the code, some specific actions should be taken to match implementations. These include, but are not limited to:

  • Integrate the rotation framework with ICPP patches
  • Unify ICCP patch subroutines to have similar structure as IB patches
  • Cross-populate geometries between IB and ICPP patches

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No fields configured for Task.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions