From cb215252cd42d02c04c8b7635e858a60ec2ddae1 Mon Sep 17 00:00:00 2001
From: Jack <72348727+Jack-GitHub12@users.noreply.github.com>
Date: Wed, 1 Jul 2026 10:50:37 -0500
Subject: [PATCH 1/2] fix(react): keep native select options readable in dark
 mode

The native <select> option popup follows the control's opaque background
and color-scheme, not option-level styles. bg-transparent left the popup
white, so dark-mode options rendered near-white text on a white surface.
The dark:bg-input/30 fallback never applied: the dark: variant is gated on
a .dark ancestor class this app never sets (theming is prefers-color-scheme
driven).

Give the select a solid themed surface (bg-popover/text-popover-foreground),
add a hover:bg-accent state, and pin color-scheme via useIsDark so the native
popup follows the active theme. Fixes the Resume approvals dropdown in
setup-mcp and mcp-install-card, and every other NativeSelect.

Closes #1227
---
 .changeset/native-select-dark-mode.md           |  5 +++++
 packages/react/src/components/native-select.tsx | 10 +++++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/native-select-dark-mode.md

diff --git a/.changeset/native-select-dark-mode.md b/.changeset/native-select-dark-mode.md
new file mode 100644
index 000000000..d2b9199b7
--- /dev/null
+++ b/.changeset/native-select-dark-mode.md
@@ -0,0 +1,5 @@
+---
+"@executor-js/react": patch
+---
+
+Keep native `<select>` dropdown options readable in dark mode. The console themes through `prefers-color-scheme` and never sets a `.dark` class, so Tailwind `dark:` utilities never matched and the native option popup rendered with a light color scheme over dark text. `NativeSelect` now uses a solid themed surface (`bg-popover`) and pins `color-scheme` to the active theme, so the browser draws a matching, readable popup.
diff --git a/packages/react/src/components/native-select.tsx b/packages/react/src/components/native-select.tsx
index 6b970cdef..5cb2fab13 100644
--- a/packages/react/src/components/native-select.tsx
+++ b/packages/react/src/components/native-select.tsx
@@ -1,24 +1,32 @@
 import * as React from "react";
 import { ChevronDownIcon } from "lucide-react";
 
+import { useIsDark } from "../hooks/use-is-dark";
 import { cn } from "../lib/utils";
 
 function NativeSelect({
   className,
   size = "default",
+  style,
   ...props
 }: Omit<React.ComponentProps<"select">, "size"> & { size?: "sm" | "default" }) {
+  const isDark = useIsDark();
   return (
     <div
       className="group/native-select relative w-fit has-[select:disabled]:opacity-50"
       data-slot="native-select-wrapper"
     >
+      {/* The native option popup follows the select's opaque background and
+          color-scheme, not option-level styles. Give it a solid themed surface
+          and pin color-scheme so options stay readable in dark mode, which is
+          driven by prefers-color-scheme (no .dark class in this app). */}
       {/* oxlint-disable-next-line react/forbid-elements */}
       <select
         data-slot="native-select"
         data-size={size}
+        style={{ colorScheme: isDark ? "dark" : "light", ...style }}
         className={cn(
-          "h-9 w-full min-w-0 appearance-none rounded-md border border-input bg-transparent px-3 py-2 pr-9 text-sm shadow-xs transition-[color,box-shadow] outline-none selection:bg-primary selection:text-primary-foreground placeholder:text-muted-foreground disabled:pointer-events-none disabled:cursor-not-allowed data-[size=sm]:h-8 data-[size=sm]:py-1 dark:bg-input/30 dark:hover:bg-input/50",
+          "h-9 w-full min-w-0 appearance-none rounded-md border border-input bg-popover text-popover-foreground px-3 py-2 pr-9 text-sm shadow-xs transition-[color,box-shadow] outline-none selection:bg-primary selection:text-primary-foreground placeholder:text-muted-foreground hover:bg-accent disabled:pointer-events-none disabled:cursor-not-allowed data-[size=sm]:h-8 data-[size=sm]:py-1",
           "focus-visible:border-ring focus-visible:ring-[3px] focus-visible:ring-ring/50",
           "aria-invalid:border-destructive aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40",
           className,

From e7a24cf254f5d1e9597822bb7b8e0a976af466c2 Mon Sep 17 00:00:00 2001
From: Jack <72348727+Jack-GitHub12@users.noreply.github.com>
Date: Wed, 1 Jul 2026 15:57:17 -0500
Subject: [PATCH 2/2] fix(react): drop remaining dead dark: aria-invalid
 utility

The dark: variant is gated on a .dark class the app never sets, so dark:aria-invalid:ring-destructive/40 never applied. Removing it is a no-op at runtime and keeps the component free of dead dark: utilities.
---
 packages/react/src/components/native-select.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/react/src/components/native-select.tsx b/packages/react/src/components/native-select.tsx
index 5cb2fab13..2d12a8706 100644
--- a/packages/react/src/components/native-select.tsx
+++ b/packages/react/src/components/native-select.tsx
@@ -28,7 +28,7 @@ function NativeSelect({
         className={cn(
           "h-9 w-full min-w-0 appearance-none rounded-md border border-input bg-popover text-popover-foreground px-3 py-2 pr-9 text-sm shadow-xs transition-[color,box-shadow] outline-none selection:bg-primary selection:text-primary-foreground placeholder:text-muted-foreground hover:bg-accent disabled:pointer-events-none disabled:cursor-not-allowed data-[size=sm]:h-8 data-[size=sm]:py-1",
           "focus-visible:border-ring focus-visible:ring-[3px] focus-visible:ring-ring/50",
-          "aria-invalid:border-destructive aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40",
+          "aria-invalid:border-destructive aria-invalid:ring-destructive/20",
           className,
         )}
         {...props}