From 73f3abe5f045ce075a279232f87dfd4fb9634460 Mon Sep 17 00:00:00 2001
From: mbeaulne <matt.beaulne@gmail.com>
Date: Thu, 20 Aug 2026 12:34:15 -0400
Subject: [PATCH] fix: treat conditional skips as successful runs

---
 src/utils/executionStatus.test.ts | 13 +++++++++++++
 src/utils/executionStatus.ts      |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/utils/executionStatus.test.ts b/src/utils/executionStatus.test.ts
index d7d0f80531..3ab1f51cbb 100644
--- a/src/utils/executionStatus.test.ts
+++ b/src/utils/executionStatus.test.ts
@@ -130,6 +130,19 @@ describe("getOverallExecutionStatusFromStats()", () => {
     ).toBe("RUNNING");
   });
 
+  test("returns succeeded when completed tasks include intentional skips", () => {
+    expect(
+      getOverallExecutionStatusFromStats({
+        SUCCEEDED: 2,
+        SKIPPED: 1,
+      }),
+    ).toBe("SUCCEEDED");
+  });
+
+  test("returns skipped when every task was skipped", () => {
+    expect(getOverallExecutionStatusFromStats({ SKIPPED: 3 })).toBe("SKIPPED");
+  });
+
   test("returns raw status values (use getExecutionStatusLabel for display)", () => {
     expect(
       getOverallExecutionStatusFromStats({
diff --git a/src/utils/executionStatus.ts b/src/utils/executionStatus.ts
index d580eea088..ed1fe2269d 100644
--- a/src/utils/executionStatus.ts
+++ b/src/utils/executionStatus.ts
@@ -98,8 +98,8 @@ const EXECUTION_STATUS_PRIORITY = [
   "WAITING_FOR_UPSTREAM",
   "QUEUED",
   "UNINITIALIZED",
-  "SKIPPED",
   "SUCCEEDED",
+  "SKIPPED",
 ] as const;
 
 export type ExecutionStatusStats = Record<string, number>;