From 2560fdaeef8502f71cbaf4904b09796589aab2ae Mon Sep 17 00:00:00 2001 From: Cosmin Staicu Date: Wed, 9 Sep 2026 18:21:09 +0300 Subject: [PATCH] chore: turn off the overload-adjacency rule the caches deliberately break S4136 fires six times across MultilayerCache, MultilayerHashCache, RedisCache and RedisHashCache, and it annotates every pull request that touches those files even though none of them introduced it. The layout it objects to is deliberate: each group of overloads sits next to the private Core helper it delegates to, so the single-key and batch groups of one name are separated by the helper that serves the first. Satisfying the rule would either move those helpers away from the overloads they support or interleave the two groups. Either reads worse than the warning. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_017fwLrS3Sbcen8v6iRkUaFB Signed-off-by: Cosmin Staicu --- .editorconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.editorconfig b/.editorconfig index 8275e9bd..02f860fe 100644 --- a/.editorconfig +++ b/.editorconfig @@ -443,6 +443,10 @@ dotnet_diagnostic.S107.severity = none dotnet_diagnostic.CA1016.severity = none dotnet_diagnostic.S3904.severity = none +# S4136: All method overloads should be adjacent. The caches group each set of overloads with the private +# Core helper they delegate to, so single-key and batch groups of the same name are deliberately apart. +dotnet_diagnostic.S4136.severity = none + csharp_using_directive_placement = outside_namespace:silent csharp_prefer_simple_using_statement = true:suggestion csharp_style_prefer_method_group_conversion = true:silent