Skip to content

feat (*): Add i18n support#2534

Open
stherrienaspnet wants to merge 23 commits into
angular-fullstack:masterfrom
stherrienaspnet:i18nSupport
Open

feat (*): Add i18n support#2534
stherrienaspnet wants to merge 23 commits into
angular-fullstack:masterfrom
stherrienaspnet:i18nSupport

Conversation

@stherrienaspnet

@stherrienaspnet stherrienaspnet commented Apr 5, 2017

Copy link
Copy Markdown
Collaborator

Add i18n support (multi-language) using angular-translate.

@benmarten

Copy link
Copy Markdown
Contributor

Not sure how we merge in this project, but looks to me your commits don't follow the convention:
-AngularJS commit message guidelines

@stherrienaspnet

Copy link
Copy Markdown
Collaborator Author

Can i change the PR text without cancelling it?

@stherrienaspnet

Copy link
Copy Markdown
Collaborator Author

I really your PR about warnings 😊

@benmarten

Copy link
Copy Markdown
Contributor

If you mean how to rename your commits, look into 'git rebase -i HEAD~1'. the force pushing your local branch to remote, i guess ;)
Renaming the PR itself should be possible here on GitHub itself...

@stherrienaspnet

Copy link
Copy Markdown
Collaborator Author

I forgot a word in my last posy , i mean I really your PR who fix warning message :)

@stherrienaspnet

Copy link
Copy Markdown
Collaborator Author

The missing word is like

@benmarten

Copy link
Copy Markdown
Contributor

Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli

@stherrienaspnet

stherrienaspnet commented Apr 9, 2017 via email

Copy link
Copy Markdown
Collaborator Author

@Awk34 Awk34 self-requested a review April 10, 2017 04:16
filter: val => val.toLowerCase()
}, {
type: 'confirm',
name: 'i18nSupport',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be simpler to just call it i18n

@Ghalleb

Ghalleb commented Jun 23, 2017

Copy link
Copy Markdown

I would really appreciate to have i8n support...

@saherrera

Copy link
Copy Markdown

is this working in the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants