From a81333a4c77b1b67770a6cd0118e515b84f44b85 Mon Sep 17 00:00:00 2001 From: Timo Saikkonen Date: Wed, 8 Jul 2026 11:52:04 +0300 Subject: [PATCH] fix(front): dedupe gitlab commit notifications by event id The push-event branch of the "keep only new/modified" filter was inverted and compared `item.ref`, which commit notifications never set (only merge request notifications carry `ref`, and it is not persisted). As a result a commit/push event was never recognized as already-seen and re-triggered a push notification on every poll (e.g. a bot commit notifying repeatedly). Remove the broken branch so push/commit events fall through to the default case, which matches by event id (the same id used to build the notification). Co-authored-by: Cursor --- src/routes/(app)/dashboard/+page.svelte | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/routes/(app)/dashboard/+page.svelte b/src/routes/(app)/dashboard/+page.svelte index 419d9be6..9066f7e5 100644 --- a/src/routes/(app)/dashboard/+page.svelte +++ b/src/routes/(app)/dashboard/+page.svelte @@ -273,9 +273,8 @@ return 'note' in n && n.note.noteable_id?.toString() === item.id; case !!n.target_id: return 'target_id' in n && n.target_id?.toString() === item.id; - case 'push_data' in n: - return !('push_data' in n && n.push_data.ref === item.ref); default: + // Push/commit events (and anything else) are keyed by their event id return item.id === n.id?.toString(); } });