Skip to content

Commit 8b2af86

Browse files
CL-7155 | fix dependency placement for rollup plugin and type packages
@rollup/plugin-typescript sat in dependencies but nothing imports it — src/util/cloud-function/cloud-functions.ts only uses rollup, @rollup/plugin-node-resolve, @rollup/plugin-commonjs and @rollup/plugin-json (verified by grepping every rollup import in src). It also declares a non-optional peer on typescript, which is a devDependency here only, so an end user installing this plugin would hit an unmet peer or drag a second typescript tree into a production install. Removed it. @types/express and @types/express-serve-static-core are type-only packages that belong in devDependencies, not dependencies. Moved them. Regenerated package-lock.json against the Contentstack npm registry and verified a from-clean rm -rf dist && npm run build still passes. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 5fb37fc commit 8b2af86

2 files changed

Lines changed: 18 additions & 32 deletions

File tree

‎package-lock.json‎

Lines changed: 16 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727
"@rollup/plugin-commonjs": "^28.0.9",
2828
"@rollup/plugin-json": "^6.1.0",
2929
"@rollup/plugin-node-resolve": "^16.0.3",
30-
"@rollup/plugin-typescript": "^12.3.0",
31-
"@types/express": "^4.17.25",
32-
"@types/express-serve-static-core": "^4.19.9",
3330
"adm-zip": "^0.6.1",
3431
"chalk": "^4.1.2",
3532
"dotenv": "^16.4.7",
@@ -40,6 +37,8 @@
4037
"rollup": "^4.63.4"
4138
},
4239
"devDependencies": {
40+
"@types/express": "^4.17.25",
41+
"@types/express-serve-static-core": "^4.19.9",
4342
"@types/jest": "^29.5.14",
4443
"@types/lodash": "^4.17.13",
4544
"@types/node": "^22.0.0",

0 commit comments

Comments
 (0)