Skip to content

Icon-button aria-labels are hard-coded English #488

Description

@dubadub

Found during review of #456.

Every visible string goes through tr.t(), but the icon-only buttons carry English aria-label/title literals: "Toggle theme", "Keyboard shortcuts", "More options", "Preferences" (templates/base.html), "Dismiss" (shopping list, pantry, recipe error banners), "Decrease scale" / "Increase scale" (recipe and menu steppers), "Close" (static/js/keyboard-shortcuts.js).

Fix: add keys to the seven locales in locales/ and swap the literals. The JS modal needs the strings passed in from the template.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions