From 0198f840915a39fb3d0773759d585001a603b3e5 Mon Sep 17 00:00:00 2001 From: Jonathan Beri Date: Wed, 26 Aug 2026 06:13:36 -0700 Subject: [PATCH] ci: don't push images on pull requests The registry login and push guards were commented out, so every PR published its matrix to ghcr.io before review. #12 added v3.3.0, v3.3.1 and v3.4.0, and all three tags were live in the registry before the PR merged. Restore the `github.event_name != 'pull_request'` guards so PRs build only, matching embeddedcontainers/zephyr. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/publish.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c15944b..f19df50 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -26,7 +26,7 @@ jobs: uses: docker/setup-buildx-action@v3 - name: Log into GitHub Container Registry - # if: github.event_name != 'pull_request' + if: github.event_name != 'pull_request' uses: docker/login-action@v3 with: registry: ghcr.io @@ -39,8 +39,7 @@ jobs: with: context: . file: ./ncs/Dockerfile - # push: ${{ github.event_name != 'pull_request' }} - push: true + push: ${{ github.event_name != 'pull_request' }} platforms: linux/amd64 provenance: false tags: ghcr.io/${{ github.repository_owner }}/ncs:${{ matrix.sdk }}SDK