From 7daf3252564eb4673deb38b7eba9180cc385080e Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Sat, 27 Jun 2026 19:05:31 +0200 Subject: [PATCH] http: accept https:// proxies again Since 663d7abe07ea (http: reject unsupported proxy URL schemes, 2026-05-05), set_curl_proxy_type() returns 0 only for the "http" and SOCKS variants via dedicated early returns, and -1 for everything else. The "https" branch configures the CURL handle for HTTPS proxying but then falls through to the trailing `return -1` intended for unknown schemes, so the caller in get_curl_handle() treats a perfectly valid https:// proxy URL as unsupported and refuses to use it. Noticed while looking into a Coverity report against the same function; the unchecked curl_easy_setopt() return values it flags are orthogonal to this fix. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin --- http.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/http.c b/http.c index 8e5a4d8bcf8eac..8c0f83136589ff 100644 --- a/http.c +++ b/http.c @@ -802,6 +802,8 @@ static int set_curl_proxy_type(CURL *result, const char *protocol) if (has_proxy_cert_password()) curl_easy_setopt(result, CURLOPT_PROXY_KEYPASSWD, proxy_cert_auth.password); + + return 0; } return -1;