Skip to content

Fixed the context option#55

Open
mensinda wants to merge 1 commit into
graphql-python:masterfrom
mensinda:master
Open

Fixed the context option#55
mensinda wants to merge 1 commit into
graphql-python:masterfrom
mensinda:master

Conversation

@mensinda

Copy link
Copy Markdown

Readded the context option which was removed in d728f80. With this change, GraphQLView behaves as described in the documentation.

From the README:

  • context: A value to pass as the context to the graphql() function.

This should also fix #52.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 93.617% when pulling 8b9333a on mensinda:master into 4183613 on graphql-python:master.

@averypmc

Copy link
Copy Markdown

Any word on this getting merged any time soon?

@mensinda

mensinda commented Nov 1, 2018

Copy link
Copy Markdown
Author

Any feedback? Will this get merged or did I miss something?

@tractorcow

Copy link
Copy Markdown

Thanks @mensinda I've been looking for this fix. :)

@guludo

guludo commented Jan 22, 2019

Copy link
Copy Markdown

I would really like to see this being merged. @syrusakbary is there anything holding this PR from being merged?

@babaMar

babaMar commented Oct 22, 2019

Copy link
Copy Markdown

is this going to be merged any time soon?

@mensinda

Copy link
Copy Markdown
Author

The last commit is from Jul 20, 2018, so this project looks abandoned to me.

@babaMar

babaMar commented Oct 22, 2019

Copy link
Copy Markdown

The last commit is from Jul 20, 2018, so this project looks abandoned to me.

yeah, same fear

@messa

messa commented Nov 5, 2019

Copy link
Copy Markdown

@syrusakbary is no more active around here. Most Graphene projects have new maintainers. Try to reach to graphql-python github org maintainers on Slack: graphenetools.slack.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passing context to GraphQLView no more supported?

7 participants