Three pre-existing gaps found during the phase-aware-cs2-review review, out of scope there:
maxOrbitCollapseRatio is declared but never applied. It exists only in REQUIRED_THRESHOLDS (tools/cs2_review.py) and the scene fixture; the orbit gate actually checks two agent-written booleans (multiAngle.degenerate, len(angles) >= 2). The live run's measured per-angle ratios were compared against nothing. Either apply the threshold to the reported ratios or remove it from the fixture and the membership set.- Two contracts disagree.
tools/cs2_review_contract.py (GOLDEN_THRESHOLDS, paintedRegionMask/colorRegion/… schema, version "cs2-knife-review-v1") is never imported by the gate, which reads thresholds from the scene fixture (version == 1). Only cs2_manifest.py and one test import the contract module.
- README sends threshold-tuners to the dead module (README "tune GOLDEN_THRESHOLDS"), so anyone hunting canonical metric names finds the wrong list. The canonical vocabulary is the fixture's
thresholds plus the report's gate tokens.
Three pre-existing gaps found during the
phase-aware-cs2-reviewreview, out of scope there:maxOrbitCollapseRatiois declared but never applied. It exists only inREQUIRED_THRESHOLDS(tools/cs2_review.py) and the scene fixture; the orbit gate actually checks two agent-written booleans (multiAngle.degenerate,len(angles) >= 2). The live run's measured per-angle ratios were compared against nothing. Either apply the threshold to the reported ratios or remove it from the fixture and the membership set.tools/cs2_review_contract.py(GOLDEN_THRESHOLDS,paintedRegionMask/colorRegion/… schema, version "cs2-knife-review-v1") is never imported by the gate, which reads thresholds from the scene fixture (version == 1). Onlycs2_manifest.pyand one test import the contract module.thresholdsplus the report's gate tokens.