Expose URLLIB connection pool KW#1008
Open
romanzdk wants to merge 2 commits into
Open
Conversation
Contributor
Author
Contributor
Author
|
@penelopus would you have a few minutes to check, please? |
Collaborator
|
@romanzdk I'll look at this today. I just want to make sure we're not going to break backwards compatibility or the way people are connecting today. From my tests is looks fairly safe but anything that touches the way we initialize the client I want to be careful of. |
Contributor
Author
|
Hey @justinpolygon , have you had a chance to take a look at this, please? :) |
Contributor
Author
|
kind reminder @justinpolygon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to specify urllib kwargs. We would use it e.g. for max size.