Skip to content

[WinML] SqueezeNet .targets file needs refactoring to move away from Copy tasks #569

Description

@adrastogi

This issue is related to the targets file here in the Windows ML samples: https://github.com/microsoft/WindowsAppSDK-Samples/blob/main/Samples/WindowsML/Resources/SqueezeNetModel.targets

The targets file leverages MSBuild's Copy task to ensure various dependencies make their way to the outputs of the WinML samples that need them.

From code inspection of the targets file below (h/t Scott Jones (@Scottj1s)), we should not be using this task, and instead leverage ItemGroup and None, either as entries in the individual project files or in a shared props file- which will give better predictability on ensuring these files land in the right places across all build scenarios.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions