From f7b52751cf39d4cfebc7283aeb3a868a5a58f675 Mon Sep 17 00:00:00 2001
From: mx57 <38256814+mx57@users.noreply.github.com>
Date: Mon, 7 Sep 2026 20:10:21 +0000
Subject: [PATCH] Add log file download feature on Web Dashboard

Added DownloadLog endpoint in HomeController to safely stream active log files with FileShare.ReadWrite and integrated download buttons into the Live Log Monitor UI.
---
 .../Controllers/HomeController.cs             | 23 +++++++++++++++++++
 .../Static/Scripts/Views/dashboard.js         |  1 +
 IntelliTrader.Web/Views/Home/Dashboard.cshtml | 19 ++++++++++++---
 magda_agent_system/agent_tasks.json           | 19 ++++++++++++++-
 4 files changed, 58 insertions(+), 4 deletions(-)

diff --git a/IntelliTrader.Web/Controllers/HomeController.cs b/IntelliTrader.Web/Controllers/HomeController.cs
index 27edbbc..ed81afb 100644
--- a/IntelliTrader.Web/Controllers/HomeController.cs
+++ b/IntelliTrader.Web/Controllers/HomeController.cs
@@ -538,6 +538,29 @@ public IActionResult Help(string lang = "en")
             return View(model);
         }
 
+        [HttpGet]
+        public IActionResult DownloadLog(string type = "general")
+        {
+            try
+            {
+                string pattern = "general".Equals(type, StringComparison.OrdinalIgnoreCase) ? "*-general.txt" : "*-trades.txt";
+                string filePath = GetLatestLogFilePath(pattern);
+
+                if (string.IsNullOrEmpty(filePath) || !System.IO.File.Exists(filePath))
+                {
+                    return NotFound("No log file found.");
+                }
+
+                string fileName = Path.GetFileName(filePath);
+                var fileStream = new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
+                return File(fileStream, "text/plain", fileName);
+            }
+            catch (Exception ex)
+            {
+                return BadRequest($"Error downloading log file: {ex.Message}");
+            }
+        }
+
         [HttpGet]
         public IActionResult PollLogs(string type = "general", int maxLines = 100)
         {
diff --git a/IntelliTrader.Web/Static/Scripts/Views/dashboard.js b/IntelliTrader.Web/Static/Scripts/Views/dashboard.js
index 1a2d24f..63acb65 100644
--- a/IntelliTrader.Web/Static/Scripts/Views/dashboard.js
+++ b/IntelliTrader.Web/Static/Scripts/Views/dashboard.js
@@ -205,6 +205,7 @@ function setLogType(type) {
         $("#logTypeGeneralBtn").removeClass("active");
     }
 
+    $("#downloadLogTopBtn").attr("href", "/Home/DownloadLog?type=" + type);
     $("#logTerminal").html('<div class="text-muted">Loading logs...</div>');
     pollLiveLogs();
 }
diff --git a/IntelliTrader.Web/Views/Home/Dashboard.cshtml b/IntelliTrader.Web/Views/Home/Dashboard.cshtml
index 29406e5..c96c8c1 100644
--- a/IntelliTrader.Web/Views/Home/Dashboard.cshtml
+++ b/IntelliTrader.Web/Views/Home/Dashboard.cshtml
@@ -457,9 +457,14 @@
     <div class="card mt-4" style="background-color: var(--card-bg); color: var(--text-color); border-radius: 4px; border: 1px solid var(--card-border); margin-top: 20px;">
         <div class="card-header" style="background-color: var(--card-header-bg); border-bottom: 1px solid var(--card-border); padding: 10px 15px; display: flex; align-items: center; justify-content: space-between;">
             <h5 class="mb-0" style="color: var(--text-light); font-size: 16px; margin: 0;"><i class="fas fa-terminal mr-2"></i>Live Log Monitor</h5>
-            <div class="btn-group btn-group-sm" role="group">
-                <button type="button" class="btn btn-sm btn-outline-light active" id="logTypeGeneralBtn" style="border-color: var(--card-border); margin-right: 5px;" onclick="setLogType('general')">General Log</button>
-                <button type="button" class="btn btn-sm btn-outline-light" id="logTypeTradesBtn" style="border-color: var(--card-border);" onclick="setLogType('trades')">Trades Log</button>
+            <div class="d-flex align-items-center">
+                <a id="downloadLogTopBtn" href="/Home/DownloadLog?type=general" class="btn btn-sm btn-outline-info mr-2" style="border-color: var(--card-border);" download>
+                    <i class="fas fa-download mr-1"></i> Download Log
+                </a>
+                <div class="btn-group btn-group-sm" role="group">
+                    <button type="button" class="btn btn-sm btn-outline-light active" id="logTypeGeneralBtn" style="border-color: var(--card-border); margin-right: 5px;" onclick="setLogType('general')">General Log</button>
+                    <button type="button" class="btn btn-sm btn-outline-light" id="logTypeTradesBtn" style="border-color: var(--card-border);" onclick="setLogType('trades')">Trades Log</button>
+                </div>
             </div>
         </div>
         <div class="card-body p-0">
@@ -566,6 +571,9 @@
                     <option value="trades" selected>Trade Logs</option>
                     <option value="general">General Logs</option>
                 </select>
+                <a id="downloadLogTerminalBtn" href="/Home/DownloadLog?type=trades" class="btn btn-sm btn-outline-info mr-2" style="border-color: var(--card-border);" download>
+                    <i class="fas fa-download mr-1"></i> Download
+                </a>
                 <button id="clearTerminalBtn" class="btn btn-sm btn-outline-secondary" style="border-color: var(--card-border); color: var(--text-color);">Clear</button>
             </div>
         </div>
@@ -636,6 +644,11 @@
             logTypeSelect.addEventListener("change", function() {
                 lastLogContent = "";
                 logTerminal.innerHTML = '<div class="text-muted">Loading logs...</div>';
+                const logType = logTypeSelect.value;
+                const downloadBtn = document.getElementById("downloadLogTerminalBtn");
+                if (downloadBtn) {
+                    downloadBtn.href = `/Home/DownloadLog?type=${logType}`;
+                }
                 fetchLogs();
             });
 
diff --git a/magda_agent_system/agent_tasks.json b/magda_agent_system/agent_tasks.json
index 42a30c7..3210c87 100644
--- a/magda_agent_system/agent_tasks.json
+++ b/magda_agent_system/agent_tasks.json
@@ -476,7 +476,7 @@
     },
     {
       "id": "web-dashboard-log-download",
-      "status": "todo",
+      "status": "done",
       "area": "web",
       "risk": "low",
       "title": "Add log file download button on Web Dashboard",
@@ -505,6 +505,23 @@
       "acceptance": [
         "Users can click export on the Stats page to download summary statistics."
       ]
+    },
+    {
+      "id": "web-dashboard-log-filtering",
+      "status": "todo",
+      "area": "web",
+      "risk": "low",
+      "title": "Add search and log level filter controls for Live Log Monitor",
+      "description": "Implement search filter input and log level filter buttons (All, Info, Warning, Error) for the live log monitor card.",
+      "allowed_paths": [
+        "IntelliTrader.Web/Views/**",
+        "IntelliTrader.Web/Controllers/**",
+        "IntelliTrader.Web/Static/**",
+        "magda_agent_system/agent_tasks.json"
+      ],
+      "acceptance": [
+        "Live log monitor terminal supports real-time text filter and log level filtering."
+      ]
     }
   ]
 }