diff --git a/QueryKit.UnitTests/ArithmeticOperatorTests.cs b/QueryKit.UnitTests/ArithmeticOperatorTests.cs index e5444c2..5cda91d 100644 --- a/QueryKit.UnitTests/ArithmeticOperatorTests.cs +++ b/QueryKit.UnitTests/ArithmeticOperatorTests.cs @@ -5,25 +5,9 @@ namespace QueryKit.UnitTests; public class ArithmeticOperatorTests { - [Theory] - [InlineData("+", "+")] - [InlineData("-", "-")] - [InlineData("*", "*")] - [InlineData("/", "/")] - [InlineData("%", "%")] - public void from_symbol_returns_the_operator_for_the_symbol(string symbol, string expectedSymbol) - { - var op = ArithmeticOperator.FromSymbol(symbol); - - op.Should().NotBeNull(); - op!.Symbol.Should().Be(expectedSymbol); - } - [Fact] - public void from_symbol_returns_null_for_an_unknown_symbol() + public void from_symbol_is_not_part_of_the_public_api() { - var op = ArithmeticOperator.FromSymbol("^"); - - op.Should().BeNull(); + typeof(ArithmeticOperator).GetMethod("FromSymbol").Should().BeNull(); } } diff --git a/QueryKit/Operators/ArithmeticOperator.cs b/QueryKit/Operators/ArithmeticOperator.cs index 70be3fb..90c1f9b 100644 --- a/QueryKit/Operators/ArithmeticOperator.cs +++ b/QueryKit/Operators/ArithmeticOperator.cs @@ -23,16 +23,6 @@ protected ArithmeticOperator(string symbol, int precedence) public static ArithmeticOperator Multiply => new MultiplyOperator(); public static ArithmeticOperator Divide => new DivideOperator(); public static ArithmeticOperator Modulo => new ModuloOperator(); - - public static ArithmeticOperator? FromSymbol(string symbol) => symbol switch - { - "+" => Add, - "-" => Subtract, - "*" => Multiply, - "/" => Divide, - "%" => Modulo, - _ => null - }; } internal class AddOperator : ArithmeticOperator