Skip to content

Update jetbrains/phpstorm-stubs#5819

Open
ondrejmirtes wants to merge 1 commit into
2.2.xfrom
update-stubs
Open

Update jetbrains/phpstorm-stubs#5819
ondrejmirtes wants to merge 1 commit into
2.2.xfrom
update-stubs

Conversation

@ondrejmirtes

Copy link
Copy Markdown
Member

No description provided.

@ondrejmirtes

Copy link
Copy Markdown
Member Author

@VincentLanglet Please could you look into the failures about null being added $element->attributes? I don't know what's right.

@VincentLanglet

Copy link
Copy Markdown
Contributor

Cant look before monday/tuesday

@VincentLanglet

Copy link
Copy Markdown
Contributor

@VincentLanglet Please could you look into the failures about null being added $element->attributes? I don't know what's right.

It's not right ; Ill need to check again but that's maybe because template has be renamed

@ondrejmirtes

Copy link
Copy Markdown
Member Author

In that case the author also needs to revert it. There’s a discussion here with him about it.

@VincentLanglet

Copy link
Copy Markdown
Contributor

In that case the author also needs to revert it. There’s a discussion here with him about it.

Now I have access to a computer, I checked again and all the Dom errors are related to DomElement::attributes.

The only change made seems to be
JetBrains/phpstorm-stubs@311f6fd#diff-6d3a9d964831128b2c68cd54da8e0583f2a8121c7db2ce1748e23c4c6498350fR1768

I dunno yet why the stub does not work then

/** @var DOMNamedNodeMap<DOMAttr> */
public $attributes;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants