Skip to content

[SMOKECO] - Follow up: Update Highest priority alarm PIXIT to dynamic values in the code. #783

Description

@jtrejoespinoza-grid

This is a follow up for: project-chip/connectedhomeip#43712

Summary Title:

Update PIXIT values from the HIEST_PRI_ALARM.

Description:

Currently the PIXIT values for HIEST_PRI_ALARM look as they are custom and should be provided as part of the certification but its not 100% clear and how is implemented from the test plan it encourages the testers to play with the values until get a valid set of values for the HIEST_PRI_ALARM which can be harmful.

Alternative from this scenario we think the following can be done to solve this issue:

In step 22 (1st HIEST_PRI_ALARM):

ensure ExpressedState is one of [BatterAlert, InterconnectSmokeAlarm (if available), InterconnectCOAlarm (if available), COState, SmokeState]
save value as last_highest_alarm
In step 25:

if last_highest_alarm was not COState, ensure ExpressedState is last_highest_alarm
else ensure ExpressedState is one of [BatterAlert, InterconnectSmokeAlarm (if available), InterconnectCOAlarm (if available), SmokeState]
save as last_highest_alarm
In step 28:

if last_highest_alarm was not InteronnectCOAlarm, ensure ExpressedState is last_highest_alarm
else ensure ExpressedState is one of [BatterAlert, InterconnectSmokeAlarm (if available), SmokeState]
save as last_highest_alarm 

Reference: https://github.com/project-chip/connectedhomeip/pull/43712/changes#r3197619179

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions