requests-oauthlib - remove dependency on types-requests because requests now comes with its own type annotations#15813
Merged
Merged
Conversation
srittau
requested changes
May 20, 2026
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
May 26, 2026
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks mostly good, but we need to add a lower bound for the requests dependencies.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
not sure how to fix that failing job |
Collaborator
|
Depends on typeshed-internal/stub_uploader#204 |
This comment has been minimized.
This comment has been minimized.
…requests` now comes with its own type annotations
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Contributor
Author
|
looks like that stub_uploader fix didn't work? or is there something else i need to change in my PR? |
Collaborator
|
Unfortunately, we hard-code a few packages in the stub uploader tests, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15814