From e9541d050c859b544d5301005cf660c1e812e574 Mon Sep 17 00:00:00 2001 From: Doug Goldstein Date: Fri, 14 Aug 2026 14:47:24 -0500 Subject: [PATCH] chore(argocd-understack): remove unnecessary ref in multi-source app These refs are never dereferenced: no source in these Applications uses $understack/ or $deploy/ in helm.valueFiles or anywhere else. This ref causes ArgoCD to crash with a runtime exception due to argoproj/argo-cd#25460 and the fix not being backported to any release branch yet. 8f9e2d73 and 92ee95eb removed these from the single-source Applications. This covers the multi-source ones that were missed, including the openstack-sync-plugins Application added in #2205, and drops the ref-only source in the snmp-exporter Application that nothing referenced. The openstack-sync-operator Application keeps both of its refs since its helm.valueFiles dereferences each one. Rendering charts/argocd-understack against both ci/ values files with the affected components enabled produces no change other than the removed ref lines. Co-Authored-By: Claude Opus 5 (1M context) --- .../templates/application-argo-events-workflows.yaml | 2 -- .../argocd-understack/templates/application-argo-events.yaml | 2 -- .../templates/application-external-secrets.yaml | 1 - .../templates/application-global-workflows.yaml | 2 -- .../templates/application-openstack-sync-plugins.yaml | 2 -- charts/argocd-understack/templates/application-openstack.yaml | 1 - .../argocd-understack/templates/application-snmp-exporter.yaml | 3 --- 7 files changed, 13 deletions(-) diff --git a/charts/argocd-understack/templates/application-argo-events-workflows.yaml b/charts/argocd-understack/templates/application-argo-events-workflows.yaml index 733288f93..e2949f2f1 100644 --- a/charts/argocd-understack/templates/application-argo-events-workflows.yaml +++ b/charts/argocd-understack/templates/application-argo-events-workflows.yaml @@ -16,11 +16,9 @@ spec: project: understack sources: - path: workflows/argo-events - ref: understack repoURL: {{ include "understack.understack_url" $ }} targetRevision: {{ include "understack.understack_ref" $ }} - path: {{ include "understack.deploy_path" $ }}/argo-events-workflows - ref: deploy repoURL: {{ include "understack.deploy_url" $ }} targetRevision: {{ include "understack.deploy_ref" $ }} syncPolicy: diff --git a/charts/argocd-understack/templates/application-argo-events.yaml b/charts/argocd-understack/templates/application-argo-events.yaml index 56d44134b..de2dfc86d 100644 --- a/charts/argocd-understack/templates/application-argo-events.yaml +++ b/charts/argocd-understack/templates/application-argo-events.yaml @@ -15,11 +15,9 @@ spec: project: understack sources: - path: components/argo-events - ref: understack repoURL: {{ include "understack.understack_url" $ }} targetRevision: {{ include "understack.understack_ref" $ }} - path: {{ include "understack.deploy_path" $ }}/argo-events - ref: deploy repoURL: {{ include "understack.deploy_url" $ }} targetRevision: {{ include "understack.deploy_ref" $ }} kustomize: diff --git a/charts/argocd-understack/templates/application-external-secrets.yaml b/charts/argocd-understack/templates/application-external-secrets.yaml index f5addc284..eff2d0b79 100644 --- a/charts/argocd-understack/templates/application-external-secrets.yaml +++ b/charts/argocd-understack/templates/application-external-secrets.yaml @@ -19,7 +19,6 @@ spec: sources: {{- if $installApp }} - path: operators/external-secrets - ref: understack repoURL: {{ include "understack.understack_url" $ }} targetRevision: {{ include "understack.understack_ref" $ }} {{- end }} diff --git a/charts/argocd-understack/templates/application-global-workflows.yaml b/charts/argocd-understack/templates/application-global-workflows.yaml index f0fd956a9..896c377e4 100644 --- a/charts/argocd-understack/templates/application-global-workflows.yaml +++ b/charts/argocd-understack/templates/application-global-workflows.yaml @@ -16,11 +16,9 @@ spec: project: understack sources: - path: components/global-workflows - ref: understack repoURL: {{ include "understack.understack_url" $ }} targetRevision: {{ include "understack.understack_ref" $ }} - path: {{ include "understack.deploy_path" $ }}/global-workflows - ref: deploy repoURL: {{ include "understack.deploy_url" $ }} targetRevision: {{ include "understack.deploy_ref" $ }} syncPolicy: diff --git a/charts/argocd-understack/templates/application-openstack-sync-plugins.yaml b/charts/argocd-understack/templates/application-openstack-sync-plugins.yaml index 002cf3e87..a4c8bc4f6 100644 --- a/charts/argocd-understack/templates/application-openstack-sync-plugins.yaml +++ b/charts/argocd-understack/templates/application-openstack-sync-plugins.yaml @@ -20,11 +20,9 @@ spec: project: understack sources: - path: components/openstack-sync-plugins - ref: understack repoURL: {{ include "understack.understack_url" $ }} targetRevision: {{ include "understack.understack_ref" $ }} - path: {{ include "understack.deploy_path" $ }}/openstack-sync-plugins - ref: deploy repoURL: {{ include "understack.deploy_url" $ }} targetRevision: {{ include "understack.deploy_ref" $ }} syncPolicy: diff --git a/charts/argocd-understack/templates/application-openstack.yaml b/charts/argocd-understack/templates/application-openstack.yaml index f65bd065c..ce808d219 100644 --- a/charts/argocd-understack/templates/application-openstack.yaml +++ b/charts/argocd-understack/templates/application-openstack.yaml @@ -16,7 +16,6 @@ spec: project: understack sources: - path: components/openstack - ref: understack repoURL: {{ include "understack.understack_url" $ }} targetRevision: {{ include "understack.understack_ref" $ }} helm: diff --git a/charts/argocd-understack/templates/application-snmp-exporter.yaml b/charts/argocd-understack/templates/application-snmp-exporter.yaml index 70b73ef46..d38e1940a 100644 --- a/charts/argocd-understack/templates/application-snmp-exporter.yaml +++ b/charts/argocd-understack/templates/application-snmp-exporter.yaml @@ -23,9 +23,6 @@ spec: - $deploy/{{ include "understack.deploy_path" $ }}/prometheus-snmp-exporter/values.yaml repoURL: https://prometheus-community.github.io/helm-charts targetRevision: 5.6.0 - - ref: understack - repoURL: {{ include "understack.understack_url" $ }} - targetRevision: {{ include "understack.understack_ref" $ }} - ref: deploy repoURL: {{ include "understack.deploy_url" $ }} targetRevision: {{ include "understack.deploy_ref" $ }}