Commit 880cd59
Use module umbrella headers in attributedstring
Summary:
The `attributedstring` headers included fine-grained public headers from other modules (`react/renderer/core`, `graphics`, `debug`, `css`, `mapbuffer`, `components/view`, `react/utils`, `react/debug`). Those headers are protected by `UmbrellaGuard.h`, so a consumer that defines `RN_STRICT_API` and includes `attributedstring` headers would hit a hard `#error` from these transitive includes.
Replace them with the module umbrellas (`<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/RendererDebug.h>`, `<React/CSS.h>`, `<React/MapBuffer.h>`, `<React/View.h>`, `<React/Utils.h>`, `<React/Debug.h>`). `ShadowView.h` (frameworks tier, no umbrella) and `ReactNativePublicFeatureFlags.h` (unguarded) stay as direct includes.
Changelog: [Internal]
Differential Revision: D1230011171 parent 148a6e0 commit 880cd59
3 files changed
Lines changed: 3 additions & 0 deletions
File tree
- packages/react-native/ReactCommon/react/renderer/attributedstring
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
0 commit comments