Skip to content

Commit e2ff131

Browse files
Dawid Małeckimeta-codesync[bot]
authored andcommitted
Seal renderer View public boundary
Summary: Reclassify the CSS-dependent View conversion headers as private implementation details: - `BackgroundImagePropsConversions.h` - `BoxShadowPropsConversions.h` - `CSSConversions.h` - `FilterPropsConversions.h` - `propsConversions.h` These headers now use the private guard and are removed from the `<React/View.h>` umbrella, along with `conversions.h`. The public `accessibilityPropsConversions.h` stays in the umbrella: it is CSS-free, and framework-tier headers such as the attributed string conversions reach the accessibility role parsers through it. `LayoutConformanceProps.h` now includes the public `conversions.h` and core `propsConversions.h` instead of the private View `propsConversions.h`, so the umbrella stays self-contained under the strict API. Following the Graphics module, renderer CSS becomes an implementation dependency of View in Buck instead of an exported one. Header publishing in Buck, CocoaPods, SwiftPM, and Gradle prefab is unchanged, consistent with other private headers, and the C++ API snapshots are unchanged. Changelog: [Internal] Differential Revision: D119970889
1 parent 4591d20 commit e2ff131

7 files changed

Lines changed: 7 additions & 12 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/components/view/BackgroundImagePropsConversions.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/featureflags/ReactNativePublicFeatureFlags.h>
1313
#include <react/renderer/core/PropsParserContext.h>

‎packages/react-native/ReactCommon/react/renderer/components/view/BoxShadowPropsConversions.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/core/PropsParserContext.h>
1313
#include <react/renderer/core/RawValue.h>

‎packages/react-native/ReactCommon/react/renderer/components/view/CSSConversions.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/core/PropsParserContext.h>
1313
#include <react/renderer/core/RawValue.h>

‎packages/react-native/ReactCommon/react/renderer/components/view/FilterPropsConversions.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/core/PropsParserContext.h>
1313
#include <react/renderer/core/RawValue.h>

‎packages/react-native/ReactCommon/react/renderer/components/view/LayoutConformanceProps.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
#include <react/cxxstableapi/UmbrellaGuard.h>
1111

1212
#include <react/renderer/components/view/YogaStylableProps.h>
13-
#include <react/renderer/components/view/propsConversions.h>
13+
#include <react/renderer/components/view/conversions.h>
14+
#include <react/renderer/core/propsConversions.h>
1415

1516
namespace facebook::react {
1617

‎packages/react-native/ReactCommon/react/renderer/components/view/React/View.h‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,10 @@
3333

3434
#include <react/renderer/components/view/AccessibilityPrimitives.h>
3535
#include <react/renderer/components/view/AccessibilityProps.h>
36-
#include <react/renderer/components/view/BackgroundImagePropsConversions.h>
3736
#include <react/renderer/components/view/BaseTouch.h>
3837
#include <react/renderer/components/view/BaseViewEventEmitter.h>
3938
#include <react/renderer/components/view/BaseViewProps.h>
40-
#include <react/renderer/components/view/BoxShadowPropsConversions.h>
41-
#include <react/renderer/components/view/CSSConversions.h>
4239
#include <react/renderer/components/view/ConcreteViewShadowNode.h>
43-
#include <react/renderer/components/view/FilterPropsConversions.h>
4440
#include <react/renderer/components/view/HostPlatformTouch.h>
4541
#include <react/renderer/components/view/HostPlatformViewEventEmitter.h>
4642
#include <react/renderer/components/view/HostPlatformViewProps.h>
@@ -60,9 +56,7 @@
6056
#include <react/renderer/components/view/YogaLayoutableShadowNode.h>
6157
#include <react/renderer/components/view/YogaStylableProps.h>
6258
#include <react/renderer/components/view/accessibilityPropsConversions.h>
63-
#include <react/renderer/components/view/conversions.h>
6459
#include <react/renderer/components/view/primitives.h>
65-
#include <react/renderer/components/view/propsConversions.h>
6660

6761
#undef RN_UMBRELLA_CONTEXT
6862
#pragma pop_macro("RN_UMBRELLA_CONTEXT")

‎packages/react-native/ReactCommon/react/renderer/components/view/propsConversions.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/components/view/conversions.h>
1313
#include <react/renderer/core/PropsParserContext.h>

0 commit comments

Comments
 (0)