Use umbrellas instead of direct includes in nativemodule/core module (#58711)

Summary:
Pull Request resolved: #58711

Changelog: [Internal]

Part of the C++ stable API migration to umbrella includes. The `nativemodule/core` headers included other public modules through their fine-grained, `UmbrellaGuard`-protected headers. They now include those modules' umbrellas instead: `<React/CallInvoker.h>`, `<React/Bridging.h>` and `<React/RuntimeExecutor.h>`.

This matters most for the iOS `RCTTurboModule*.h` headers, which are exported, have no guard, and are not reached through `<React/NativeModuleCore.h>`. Includes of the module's own headers and all `.cpp`/`.mm` files are unchanged. No functional change.

Reviewed By: cortinico

Differential Revision: D122123056

fbshipit-source-id: 2fcb2fa2e73c3adf5b5317f3e700b19f35a449e8

Author: j-piasecki

packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec

@@ -49,5 +49,7 @@ Pod::Spec.new do |s|
   add_dependency(s, "ReactCommon", :subspec => "turbomodule/core", :additional_framework_paths => ["react/nativemodule/core"])
   add_dependency(s, "React-NativeModulesApple", :additional_framework_paths => ["build/generated/ios"])
 
+  add_rn_third_party_dependencies(s)
+
   mark_as_react_native_build(s)
 end

packages/react-native/Libraries/PushNotificationIOS/React-RCTPushNotification.podspec

@@ -49,6 +49,7 @@ Pod::Spec.new do |s|
   add_dependency(s, "ReactCommon", :subspec => "turbomodule/core", :additional_framework_paths => ["react/nativemodule/core"])
   add_dependency(s, "React-NativeModulesApple")
 
+  add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)
 
   mark_as_react_native_build(s)

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/CxxTurboModuleUtils.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
-#include <ReactCommon/CallInvoker.h>
+#include <React/CallInvoker.h>
 #include <ReactCommon/TurboModule.h>
 #include <functional>
 #include <memory>

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h

@@ -15,8 +15,8 @@
 
 #include <jsi/jsi.h>
 
-#include <ReactCommon/CallInvoker.h>
-#include <react/bridging/EventEmitter.h>
+#include <React/Bridging.h>
+#include <React/CallInvoker.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleBinding.h

@@ -11,8 +11,8 @@
 
 #include <string>
 
+#include <React/Bridging.h>
 #include <jsi/jsi.h>
-#include <react/bridging/LongLivedObject.h>
 
 #include <ReactCommon/TurboModule.h>
 

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleUtils.h

@@ -9,8 +9,8 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
+#include <React/Bridging.h>
 #include <jsi/jsi.h>
-#include <react/bridging/LongLivedObject.h>
 #include <cassert>
 #include <functional>
 #include <string>

packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleWithJSIBindings.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
-#include <ReactCommon/CallInvoker.h>
+#include <React/CallInvoker.h>
 #include <jsi/jsi.h>
 
 namespace facebook::react {

packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.h

@@ -11,10 +11,10 @@
 
 #include <string>
 
-#include <ReactCommon/CallInvoker.h>
+#include <React/Bridging.h>
+#include <React/CallInvoker.h>
 #include <ReactCommon/TurboModule.h>
 #include <jsi/jsi.h>
-#include <react/bridging/CallbackWrapper.h>
 #include <react/jni/JCallback.h>
 
 namespace facebook::react {

packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/React-NativeModulesApple.podspec

@@ -37,6 +37,7 @@ Pod::Spec.new do |s|
     s.source_files = podspec_sources("ReactCommon/**/*.{mm,cpp,h}", "ReactCommon/**/*.{h}")
 
     s.dependency "ReactCommon/turbomodule/core"
+    s.dependency "ReactCommon/turbomodule/coreUmbrella"
     s.dependency "React-bridging"
     s.dependency "React-callinvoker"
     s.dependency "React-Core"

packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTInteropTurboModule.h

@@ -12,7 +12,7 @@
 #import <string>
 #import <vector>
 
-#import <ReactCommon/TurboModule.h>
+#import <React/NativeModuleCore.h>
 #import <jsi/jsi.h>
 
 #import "RCTTurboModule.h"