Skip to content

Builds failing: stellar-rpc v26 in the future image no longer compiles on stable Rust #960

Description

@leighmcculloch

What version are you using?

main at 9809fb4, and every PR off it, e.g. https://github.com/stellar/quickstart/actions/runs/30425524938/job/90491234151?pr=958.

What did you do?

Opened a PR, which builds all images in images.json.

What did you expect to see?

Green builds.

What did you see instead?

The future image fails compiling rpc's Rust libs: error[E0512]: cannot transmute between types of different sizes in ethnum-1.5.2/src/error.rs:16. ethnum 1.5.2 assumed std's TryFromIntError was zero-sized, which was never guaranteed, and on current stable Rust it isn't. We build with RUST_TOOLCHAIN_VERSION=stable, so this landed on its own.

Only future breaks: it pins rpc v26.0.0, while latest and testing are on v27.1.1, which is fine. Same error was fixed elsewhere by bumping ethnum to 1.5.3 (stellar-experimental/one-way-channel#22), but we don't need rpc v26 anymore, so perhaps just upgrade the futurenet pins instead.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions