Surfaced by CodeRabbit on #48 (client.rs ~L179-192). Pre-existing — engine original client.rs:179 has the identical unwrap_or(true); ported unchanged.
execute_direct defaults successful to true when the payload omits it, even if error is set. Consumers gate on the flag — checked_execute in google_docs.rs drives document creation from it — so an error payload can be stored as document content.
Fix: successful = successful && error.is_none() (after trimming/emptying the error string).
Surfaced by CodeRabbit on #48 (
client.rs~L179-192). Pre-existing — engine originalclient.rs:179has the identicalunwrap_or(true); ported unchanged.execute_directdefaultssuccessfultotruewhen the payload omits it, even iferroris set. Consumers gate on the flag —checked_executeingoogle_docs.rsdrives document creation from it — so an error payload can be stored as document content.Fix:
successful = successful && error.is_none()(after trimming/emptying the error string).