refactor: fix vulnerabilities - #37
Merged
Merged
Conversation
`npm update --save lodash`
`npm update --save rimraf`
`npm update --save @eslint/eslintrc @eslint/js \
@typescript-eslint/eslint-plugin @typescript-eslint/parser eslint \
eslint-config-prettier eslint-plugin-jest`
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
`npm update --save mongodb-memory-server` Note that with this new mongodb version, the `FindOptions` type is not generic anymore.
`npm update --save jest ts-jest @types/jest`
There seem to be a bug in jest 30, which prevents asserting
`.rejects.toThrow(new Error("..."))`
It complains that the thrown error is not the same object as the
expected one 🙄
`npm audit fix`
LucVidal360
force-pushed
the
main-34-vulnerabilities
branch
from
July 20, 2026 08:32
ad29580 to
92fcb68
Compare
Most dependencies' newer version require at least node 20.
The test "should directly reject for invalid aggregate pipelines (empty from)" was successful, but force jest to wait 30 seconds before ending cleanly. This came from a `setTimeout` which was not cleaned because of an unexepected thrown error. Moving the clearTimeout in a finally fix this issue. You may ignore whitespaces to review this commit. Next commit will further refactor the code by moving the check on `options.dontCount` inside `getTotalEntries`.
This is a minor change (not a patch) because of the new requirement on node version.
LucVidal360
force-pushed
the
main-34-vulnerabilities
branch
from
July 20, 2026 08:56
92fcb68 to
2f45b99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
npmcomplains there are vulnerabilities in our libsDisclaimer
Don't worry, the high number of line changes is mostly about
package-lock.json😉Changes
setTimeoutwhich was not cleared because of a thrown error