Repository navigation
feat: support embedded agent configuration options - #23
Merged
Merged
Conversation
Add custom instructions, workspace and skill opt-outs, and tool allowlists with package-consumer and Workspace regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented MCP discovery workflow needs name conversion to produce working allowlists.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds configuration options for embedding the agent while preserving default behavior.
Changes:
- Supports custom instructions and Workspace/skill opt-outs.
- Adds runtime, MCP, and Workspace tool allowlists.
- Documents embedding options and expands regression coverage.
| File | Description |
|---|---|
| tests/agent.workspaceToolsMigrationContract.test.ts | Tests Workspace tool filtering. |
| scripts/test-package-consumer.mjs | Exercises embedded configuration through package exports. |
| README.md | Documents embedding options. |
| api/core/agent/publicContracts.ts | Applies allowlists to Workspace tools. |
| api/core/agent/index.ts | Implements factory configuration options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Document MCP allowlist key conversion and verify enabled bundled skills are discovered and registered only when skill support is enabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom instructions, workspace and skill opt-outs, and tool allowlists with package-consumer and Workspace regression coverage.
Summary
Describe the problem and the changes in this pull request.
Validation
npm run typechecknpm run buildnpm testChecklist