This repository was archived by the owner on Sep 23, 2026. It is now read-only.
Conversation
Collaborator
|
I don't think this actually gives us anything, as you'd still need either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR modifies the Dockerfile to allow it to take a parameter to select the MongoDB version that the image will be built from.
How was it tested?
Locally using Docker Desktop
Is there a Github issue this is resolving?
This resolves 5e-bits/5e-srd-api#1297.
Did you update the docs in the API? Please link an associated PR if applicable.
The API is unaffected by this change; however I did update the README.md to describe the modified build command.
Here's a fun image for your troubles