Skip to content

checkpoint conversion support for deepseek v4#4336

Open
snehalv2002 wants to merge 1 commit into
dsv4-bug-fixesfrom
dsv4-conversion-pr
Open

checkpoint conversion support for deepseek v4#4336
snehalv2002 wants to merge 1 commit into
dsv4-bug-fixesfrom
dsv4-conversion-pr

Conversation

@snehalv2002

@snehalv2002 snehalv2002 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Adding support for DeepSeek V4-Flash checkpoint conversion through the conversion utility in maxtext. Supports scanned and unscanned conversion.

FIXES: b/509930555 (scanned conversion bug), b/509931406 (unscanned conversion bug)

Tests

509930698 This comment defines the relevant test scripts and test outputs we used to verify the checkpoint conversion. We verified parity between the output of the reference HuggingFace implementation provided by DeepSeek against our own MaxText implementation.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.70270% with 180 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtext/checkpoint_conversion/utils/param_mapping.py 1.83% 107 Missing ⚠️
src/maxtext/checkpoint_conversion/to_maxtext.py 4.10% 70 Missing ⚠️
src/maxtext/checkpoint_conversion/utils/utils.py 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@snehalv2002 snehalv2002 force-pushed the dsv4-conversion-pr branch 3 times, most recently from f575be7 to 062ca0a Compare July 9, 2026 00:18
@snehalv2002 snehalv2002 changed the base branch from main to dsv4-bug-fixes July 9, 2026 00:21
@parambole parambole mentioned this pull request Jul 13, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants