Skip to content

chore: remove prototypes, fold frontend lint into tests, pin actions - #672

Open
kcarnold wants to merge 1 commit into
mainfrom
claude/remove-prototypes-cleanup
Open

kcarnold wants to merge 1 commit into
mainfrom
claude/remove-prototypes-cleanup

Conversation

@kcarnold

@kcarnold kcarnold commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #671.

Changes

  • Remove prototype-mindmap/ (now in its own repo) and prototype-word-bank/. Both remain in git history.
  • Remove mindmap-tests.yml. Its mindmap job goes with the folder. The add-in/backend handoff checks are superseded by the OAuth mechanism in review. The underlying frontend and backend unit tests still run in frontend-tests.yml and backend-tests.yml.
  • Fold frontend lint into frontend-tests.yml. Lint is now a step in the existing unit job, which uses read-only permissions and npm ci. add-in.yml is deleted. It had contents: write + checks: write and used npm install.
  • Pin actions/checkout, setup-node and upload-artifact to commit SHAs with version comments, matching how the docker/* actions are already pinned. Dependabot updates both the SHA and the comment.
  • Update one doc reference to the mindmap prototype's new location.

Checks

  • npm run lint in frontend/ passes (0 errors, 3 pre-existing warnings).
  • All workflow files parse.

Before merging

If branch protection requires the Run linters or mindmap-tests checks, remove them from the required list. Otherwise PRs will wait on checks that no longer run. The Unit tests (Vitest) job name is unchanged on purpose.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KVVCrykaVNbxhiErLNEwja


Generated by Claude Code

- Remove prototype-mindmap (now its own repo) and prototype-word-bank, plus
  mindmap-tests.yml. Its add-in/backend handoff checks are superseded by the
  OAuth mechanism in review; the same unit tests still run in
  frontend-tests.yml and backend-tests.yml.
- Fold the frontend lint job (add-in.yml) into frontend-tests.yml's unit job.
  Drops add-in.yml's contents/checks write permissions and its npm install in
  favour of the existing read-only npm ci job.
- Pin actions/checkout, setup-node and upload-artifact to commit SHAs, matching
  the docker/* actions. Dependabot updates the SHA and version comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KVVCrykaVNbxhiErLNEwja
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants