Repository navigation
Disable dll copies by vcpkg to avoid race condition - #3412
Merged
Merged
Conversation
This variable is explained at: https://learn.microsoft.com/en-us/vcpkg/users/buildsystems/cmake-integration#vcpkg_applocal_deps Parallel ninja builds call "vcpkg z-applocal" in parallel which can creaate collisions. X_VCPKG_APPLOCAL_DEPS_SERIALIZED (from AOMediaCodec#3408) did not resolve this because CMake's Ninja generator inlines target post-build commands directly into the linker rule and does not place them in the terminal/console pool. VCPKG_APPLOCAL_DEPS=OFF disables the post build copies. We still need to find the dlls so the the build folder is added to the path. It should fix the issues we've been seeing on the Windows CI with vcpkg.
y-guyon
approved these changes
Oct 13, 2026
wantehchang
approved these changes
Oct 13, 2026
wantehchang
reviewed
Oct 13, 2026
wantehchang
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable is explained at:
https://learn.microsoft.com/en-us/vcpkg/users/buildsystems/cmake-integration#vcpkg_applocal_deps
Parallel ninja builds call "vcpkg z-applocal" in parallel which can creaate collisions.
X_VCPKG_APPLOCAL_DEPS_SERIALIZED (from #3408) did not resolve this because CMake's Ninja generator inlines target post-build commands directly into the linker rule and does not place them in the terminal/console pool.
VCPKG_APPLOCAL_DEPS=OFF disables the post build copies. We still need to find the dlls so the the build folder is added to the path.
It should fix the issues we've been seeing on the Windows CI with vcpkg.