FIX: Keep the column datetime unit when re-binning gauge accumulations - #44
Merged
Merged
Conversation
_apply_match raised IndexError: dimension coordinate 'time' conflicts between indexed and indexing objects, taking five tests in test_radclss.py down on every platform since ARM-Development#42 merged. The scheduled run hours before that merge was green. A column time coordinate is built from base_time, which carries second resolution. _accumulate_to_grid subtracted a pandas Timedelta from it to form the leading interpolation edge, and to_timedelta64 carries sub-second precision, so the subtraction promoted the whole edges array to nanoseconds. interp handed that unit to the result, and _apply_match then tried to write a nanosecond-stamped result into a second-resolution column. The timestamps were identical; only the unit differed. Whether that is fatal depends on the xarray version, which is why it never reproduced locally. xarray 2025.6.1, which CI pins, compares coordinates by dtype as well as by value and rejects the write. Newer xarray compares by value and accepts it. The existing tests could not catch this: they build column grids with pd.date_range, which is always nanoseconds, so the promotion is invisible. The new test uses a second-resolution grid like the real pipeline and asserts on dtype directly, so it holds on any xarray version rather than relying on one to raise. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue where the column datetime unit was dropped when re-binning gauge accumulations, to ensure compatibility for older xarray. Co-written by Claude Opus 5.