Repository navigation
fix: SG-45532: Update presentation pointer while drawing with Annotation (Beta) - #1451
Open
cedrik-fuoco-adsk wants to merge 1 commit into
Conversation
…ion (Beta) The Presentation Mode pointer is drawn from State.pointerPositionNormalized, which only recordPixelInfo updates. The beta engine's drag handlers consume pointer drag events without calling it, so the pointer froze (or faded out) on the presentation device until the stroke was released. Call recordPixelInfo from _pointer_location. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
force-pushed
the
SG-45532-fix-presentation-pointer-annotation
branch
from
October 9, 2026 17:22
63d421b to
fc7043e
Compare
cedrik-fuoco-adsk
marked this pull request as ready for review
October 9, 2026 17:25
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
October 9, 2026 17:25
| default sequence) the innermost entry may be a virtual composite image whose | ||
| source name is not valid for eventToImageSpace. | ||
| """ | ||
| # Update RV's shared pointer state |
Contributor
There was a problem hiding this comment.
Is this comment relevant? This is only describing what the function does.
Contributor
Author
There was a problem hiding this comment.
For me, recordPixelInfo doesn't really tell me what's the intent of calling it here
eloisebrosseau
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SG-45532: Update presentation pointer while drawing with Annotation (Beta)
Linked issues
none
Summarize your change.
Call
recordPixelInfofrom the Annotation (Beta) engine's_pointer_location, so the Presentation Mode pointer follows the cursor while drawing.Describe the reason for the change.
With
Pointerenabled in Presentation Settings, the pointer on the presentation device froze at the press position while drawing with the Annotation (Beta) tools.The Presentation Mode pointer is drawn from
State.pointerPositionNormalized, which onlyrecordPixelInfoupdates. The beta engine's drag handlers consume pointer drag events without calling it, so rvui's handlers never update that state during a stroke.Describe what you have tested and on which operating system.
Tested the different tools on MacOS
Add a list of changes, and note any that might need special attention during the review.
annotate_beta_engine.py:_pointer_locationcallsextra_commands.recordPixelInfo(event)with the raw event (it applies the device pixel ratio itself). The call is wrapped so a failure never aborts a stroke.imagesAtPixelcall per pointer event.If possible, provide screenshots.
N/A