Repository navigation
Conversation
Collaborator
|
The Windows CI failure are something that's already been fixed, and if you rebase on the current main, it will go away. |
Add a minimal standalone renderer that is built against the installed OSL, as requested in AcademySoftwareFoundation#2175. testrender and testshade are built as part of OSL, so they cannot notice a broken install. This test is a separate CMake project that uses find_package(OSL), compiles its shaders with the installed oslc, links OSL::oslexec, renders a small image, and compares it against a reference. The renderer is the path tracer from "Ray Tracing in One Weekend" with its materials replaced by OSL shaders. Random numbers are reseeded per scanline so the image is the same for any number of threads. Assisted-by: Claude Code / Opus-5.5 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
jinhgkim
force-pushed
the
example-tinyrender
branch
from
October 7, 2026 05:45
b03c3fc to
234a2a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2175.
Add a minimal standalone renderer that is built against the installed OSL, as requested in #2175.
testrender and testshade are built as part of OSL, so they cannot notice a broken install. This test is a separate CMake project that uses find_package(OSL), compiles its shaders with the installed oslc, links OSL::oslexec, renders a small image, and compares it against a reference.
The renderer is the path tracer from "Ray Tracing in One Weekend" with its materials replaced by OSL shaders. Random numbers are reseeded per scanline so the image is the same for any number of threads.
Assisted-by: Claude Code / Opus-5.5
(Hold me closer, tiny render 🎵)
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.