Repository navigation
Conversation
…te it A libwayland copied from the Ubuntu build image clashes with the host's newer Mesa: crashes or a blank webview on e.g. Arch/KDE Wayland (tauri-apps/tauri#15665, tauri-apps/tauri#15976). Set LINUXDEPLOY_EXCLUDED_LIBRARIES=libwayland-* for the Tauri builds (linuxdeploy honors it from @tauri-apps/cli 2.12, tauri-apps/tauri#16062), and run the host-ABI gate on the Tauri AppImage. host-abi-gate.sh gains HOST_ABI_LIBS_LIST so this bundle can keep glib, which its GTK/WebKitGTK needs.
|
@greptileai review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
@greptileai review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdeeea8b27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@greptileai review |
|
@TimeToBuildBob review |
🤖 AI code reviewThis PR adds a host-ABI gate for the Tauri AppImage in the release workflow, sets LINUXDEPLOY_EXCLUDED_LIBRARIES=libwayland-* to prevent bundling libwayland, and extends host-abi-gate.sh with a HOST_ABI_LIBS_LIST environment variable to replace the default library list. It also adds a new test file for the gate script. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (3) — the diff as I read it
Reviewed Maintainer commands
|
A Discord user on CachyOS (KDE Plasma 6, Wayland) gets segfaults clicking tray items in the v0.14.0 Tauri AppImage. Not reproduced yet (we've asked for a backtrace), but the bundle matches a known upstream failure: the v0.14.0 AppImage ships
libwayland-client/-cursor/-egl/-serverfrom the Ubuntu 24.04 build image but no Mesa, so host Mesa 25+ loads on top of an older libwayland. That's tauri-apps/tauri#15665 and tauri-apps/tauri#15976 (crash or blank webview), fixed upstream by tauri-apps/tauri#16062 (newer linuxdeploy, shipped in@tauri-apps/cli2.12.0). It's the same class as #1484, which only covers the Qt bundle.Changes
release.yml(build-tauri):LINUXDEPLOY_EXCLUDED_LIBRARIES=libwayland-*, which linuxdeploy (run by Tauri's bundler) reads.host-abi-gate.shon the Tauri AppImage, checking onlylibwayland-*.host-abi-gate.sh:HOST_ABI_LIBS_LISTreplaces the default list. The Tauri AppImage keeps glib on purpose, because its bundled GTK 3 / WebKitGTK need the glib they were built against. The Qt gate is unchanged.Merge with the v0.14.1 aw-tauri bump. The current aw-tauri pin (1d52445) builds with cli 2.11.4, whose linuxdeploy ignores the exclude variable, so I expect this PR's Linux Tauri jobs to fail the new gate. That's the gate catching the v0.14.0 bundle. aw-tauri master is on cli 2.12.0 (ActivityWatch/aw-tauri@c8c566c), so it should pass once the submodule is bumped.
Tested locally:
bash -n, the YAML parses, and the gate's three cases on a fake tree: libwayland present → 1; only glib with the wayland list → 0; only glib with the default list → 1. Extracting a real AppImage needs Linux, so CI is the check there.Complementary runtime mitigation: ActivityWatch/aw-tauri#286 (
WEBKIT_DISABLE_DMABUF_RENDERER=1under an AppImage).