Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@greptileai review |
|
The macOS and Windows Tauri builds ship aw-notify; on Linux it was only a loose folder in the zip. aw-notify is aw-notify-rs, a single Rust binary like awatcher, so with AW_EXTRAS build it before aw-tauri (aw-tauri now goes last in SUBMODULES) and stage target/<dir>/aw-notify into src-tauri/modules/, failing if it's missing.
3034c6b to
262c5b6
Compare
|
Reworked in 262c5b6. The first version wrongly treated aw-notify as the Python PyInstaller app; the submodule is aw-notify-rs, so it's now built before aw-tauri and staged like awatcher. @greptileai review |
|
@TimeToBuildBob review |
🤖 AI code reviewThis PR bundles aw-notify into the Linux Tauri deb/rpm/AppImage builds. It moves the aw-tauri submodule to the end of the SUBMODULES list so it is built after aw-notify and aw-watcher-input when AW_EXTRAS is set, and adds a staging step in the build loop that copies the aw-notify binary into aw-tauri/src-tauri/modules/ when AW_EXTRAS is true, failing the build if the binary is missing. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
Follow-up to #1499, which bundles aw-awatcher + aw-sync. The macOS and Windows Tauri builds already ship aw-notify (the
.app's Resources, and the Inno installer copies all ofdist/activitywatch). On Linux it was only a loose folder in the zip, so the AppImage, .deb and .rpm had no notifications.The
aw-notifysubmodule is aw-notify-rs, a single Rust binary like awatcher. So:SUBMODULES: aw-tauri now goes last, after theAW_EXTRASmodules (aw-notify, aw-watcher-input), so aw-notify is built before the Tauri bundle step. The non-Tauri order is unchanged.AW_EXTRAS=true(set in release CI), copyaw-notify/target/<targetdir>/aw-notifyintosrc-tauri/modules/aw-notify, and fail if it's missing, as for awatcher.Checked: the module order from
make -n buildfor Tauri with and without extras,SKIP_SERVER_RUST, and non-Tauri;bash -non the expanded loop; and a simulated staging run on a fake tree (stages aw-awatcher, aw-sync and aw-notify; exits 1 when aw-notify is missing).