Skip to content

build(linux): bundle aw-notify into the Linux Tauri deb/rpm/AppImage - #1510

Open
ErikBjare wants to merge 1 commit into
masterfrom
feat/linux-tauri-bundle-aw-notify
Open

ErikBjare wants to merge 1 commit into
masterfrom
feat/linux-tauri-bundle-aw-notify

Conversation

@ErikBjare

@ErikBjare ErikBjare commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #1499, which bundles aw-awatcher + aw-sync. The macOS and Windows Tauri builds already ship aw-notify (the .app's Resources, and the Inno installer copies all of dist/activitywatch). On Linux it was only a loose folder in the zip, so the AppImage, .deb and .rpm had no notifications.

The aw-notify submodule is aw-notify-rs, a single Rust binary like awatcher. So:

  • SUBMODULES: aw-tauri now goes last, after the AW_EXTRAS modules (aw-notify, aw-watcher-input), so aw-notify is built before the Tauri bundle step. The non-Tauri order is unchanged.
  • Staging: with AW_EXTRAS=true (set in release CI), copy aw-notify/target/<targetdir>/aw-notify into src-tauri/modules/aw-notify, and fail if it's missing, as for awatcher.

Checked: the module order from make -n build for Tauri with and without extras, SKIP_SERVER_RUST, and non-Tauri; bash -n on the expanded loop; and a simulated staging run on a fake tree (stages aw-awatcher, aw-sync and aw-notify; exits 1 when aw-notify is missing).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T12:10:00.732928Z 262c5b6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ErikBjare

Copy link
Copy Markdown
Member Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Reorders build steps to include aw-notify in Linux packages.

The reviewed changes appear safe to merge; no blocking issue was established.

What we checked:

  • Old notification binaries are cleared: The build removes the entire staging directory before copying modules. It copies aw-notify only when AW_EXTRAS=true.

Summary

The PR moves aw-tauri after optional extras and stages the Rust aw-notify binary for Linux builds with AW_EXTRAS=true.

  • Copy failures and a missing notification binary stop the build.
  • No actionable new issues were found.
  • The previous-review ancestry checks failed, so the full PR diff was reviewed. No previous finding threads were supplied.
  • Package contents and startup behavior could not be checked directly because the relevant submodules were not checked out.

Reviews (2) · Last reviewed commit: "build(linux): bundle aw-notify into the ..." · Reviewed by Greptile

The macOS and Windows Tauri builds ship aw-notify; on Linux it was only a
loose folder in the zip. aw-notify is aw-notify-rs, a single Rust binary
like awatcher, so with AW_EXTRAS build it before aw-tauri (aw-tauri now
goes last in SUBMODULES) and stage target/<dir>/aw-notify into
src-tauri/modules/, failing if it's missing.
@ErikBjare
ErikBjare force-pushed the feat/linux-tauri-bundle-aw-notify branch from 3034c6b to 262c5b6 Compare October 7, 2026 12:06
@ErikBjare

Copy link
Copy Markdown
Member Author

Reworked in 262c5b6. The first version wrongly treated aw-notify as the Python PyInstaller app; the submodule is aw-notify-rs, so it's now built before aw-tauri and staged like awatcher. @greptileai review

@ErikBjare

Copy link
Copy Markdown
Member Author

@TimeToBuildBob review

@TimeToBuildBob

TimeToBuildBob commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🤖 AI code review

This PR bundles aw-notify into the Linux Tauri deb/rpm/AppImage builds. It moves the aw-tauri submodule to the end of the SUBMODULES list so it is built after aw-notify and aw-watcher-input when AW_EXTRAS is set, and adds a staging step in the build loop that copies the aw-notify binary into aw-tauri/src-tauri/modules/ when AW_EXTRAS is true, failing the build if the binary is missing.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (1) — the diff as I read it
  • Makefile — Moves aw-tauri to the end of SUBMODULES and adds staging of the aw-notify binary into src-tauri/modules when AW_EXTRAS is true.

Reviewed 262c5b68ce87 · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 9s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants