fix(parse): guard _ts against non-string timestamp values - #32
Open
yunaremaia wants to merge 1 commit into
Open
Conversation
A numeric timestamp (e.g. 1718000000 instead of ISO 8601 string) in a malformed transcript crashed _ts with AttributeError when calling value.replace(). Guard with isinstance check so non-string values return None instead. Closes AgentPostmortem#20
|
Welcome, @yunaremaia, and thanks for your first pull request to Agentrace. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What — Guards
_ts()inagentrace/parse.pyagainst non-string timestamp values (e.g., numeric1718000000instead of ISO 8601 strings).Why — A malformed transcript with a numeric
timestampfield crashed_tswithAttributeErrorwhen calling.replace()on a non-string value. The existing guard only checked falsy values, not type.How — Added
isinstance(value, str)check before string operations. Non-string values now returnNonegracefully, consistent with how missing/invalid timestamps are handled elsewhere.Test
test_non_string_timestamp_does_not_crashthat writes a synthetic transcript with numeric timestamps (1718000000,1718000600) and asserts the run parses withstarted_atandended_atset toNone.Closes #20