fix: reject unknown CLI options before scanning - #13
Merged
royalpinto007 merged 1 commit intoSep 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unknown CLI flags are currently ignored; for example,
--output=report.jsoncan produce a normal scan even though no output file is written. Reject unrecognized long and short options with a message identifying the offending argument and exit code 2, before scanning.Closes #9.
Checklist
npm test: 14 passed)CHANGELOG.mdentry and patch version bump as requested by the contribution guideNotes
Added CLI regression cases for an unknown option with a separate value, an
=value, and a short flag. The test failed on the parent code:--output report.jsonreported a missing path instead of the unknown option. Added checks that both supported value-option forms still produce a clean JSON scan. The complete suite andgit diff --checkpass (Windows, Node.js).AI assistance was used to implement this change and run the checks above.