validate gold file parsing and add tests - #26
Merged
royalpinto007 merged 2 commits intoSep 6, 2026
Merged
Conversation
|
Welcome, @mokshagnachintha, and thanks for your first pull request to VaultRAG. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
Collaborator
|
Nice work - almost there. One acceptance criterion from #25 is missing: reject duplicate case ids with a ValueError naming the id. Please add that check plus its test, then it is good to merge. |
Contributor
Author
|
Added duplicate case id validation and unit test. Thanks for the review! |
|
This is in, @mokshagnachintha. Really appreciate it. Good, focused change. Exactly the kind of thing VaultRAG needs. If VaultRAG is useful to you, a star goes a long way. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add robust input validation for vaultrag.evaluate.load_gold and unit tests to ensure malformed gold files produce clear ValueError messages. Fixes #25.