Skip to content

Reject empty document fields at the API boundary #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royalpinto007 merged 1 commit into from
Sep 8, 2026
Merged

Reject empty document fields at the API boundary #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,20 @@ async def test_health(client):
assert r.status_code == 200


async def test_empty_document_text_is_rejected(client):
r = await client.post(
"/documents",
json={
"id": "empty-text",
"title": "Empty Text",
"source": "wiki",
"acl": ["engineering"],
"text": "",
},
)
assert r.status_code == 422


async def test_ask_requires_identity(client):
r = await client.post("/ask", json={"question": "what is the bonus"})
assert r.status_code == 422, "no user header should be rejected, not defaulted"
Expand Down
6 changes: 3 additions & 3 deletions vaultrag/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ class AskResponse(BaseModel):


class DocIn(BaseModel):
id: str
title: str
id: str = Field(min_length=1)
title: str = Field(min_length=1)
source: str
text: str
text: str = Field(min_length=1)
acl: list[str] = Field(description="user ids and/or group names. Empty means nobody can see it.")
owner: str | None = None
department: str | None = None
Expand Down
Loading