fix(uploader): render upload progress inside the dropzone - #4143
Merged
Conversation
tvdeyen
marked this pull request as draft
August 11, 2026 16:17
tvdeyen
force-pushed
the
uploader-progress-in-dropzone
branch
from
August 11, 2026 16:33
b82aefe to
9ded264
Compare
tvdeyen
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4143 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 352 352
Lines 9292 9293 +1
=======================================
+ Hits 9133 9134 +1
Misses 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
uploader-progress-in-dropzone
branch
2 times, most recently
from
August 14, 2026 10:08
ee4c646 to
4302fbe
Compare
Previously the upload progress always mounted on document.body, so it floated over the whole admin regardless of where the upload started. Mount it inside the dropzone element instead (falling back to the body) and let a layout attribute pick the shape: "row" for resource tables and "card" for the picture archive grid, so the indicators match the view they upload into.
tvdeyen
force-pushed
the
uploader-progress-in-dropzone
branch
from
August 17, 2026 10:06
4302fbe to
ef91220
Compare
tvdeyen
marked this pull request as ready for review
August 17, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
While an upload is running, the progress indicator always mounted on
document.body, so it floated over the whole admin regardless of where theupload was started. This moves the progress into the dropzone that received the
files (falling back to the body when an uploader has no dropzone), and adds a
layoutattribute so the indicators fit the view they belong to:rowforresource tables and
cardfor the picture archive's thumbnail grid.Notable changes
Alchemy::Admin::UploaderButtongains alayoutoption that is reflected onto<alchemy-uploader>and, in turn, onto the<alchemy-upload-progress>element,which the stylesheet uses to switch between the row and card layouts. The
picture archive opts into
layout: "card"; every other uploader keeps thedefault
rowlayout, so existing behaviour is unchanged.Screenshots
Visual change: the upload progress now renders inside the archive/dropzone,
shown as a thumbnail grid in the picture library and as stacked rows elsewhere.
Checklist