Skip to content

Changes in TPC residuals validation #15524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahor02 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Changes in TPC residuals validation #15524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9755ce1
Changes in TPC residuals validation
shahor02 Jun 14, 2026
bc73322
Suppres compareToHelix and min.ref. |q/pT| cuts for extrapolated tracks
shahor02 Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions Detectors/GlobalTrackingWorkflow/tpcinterpolationworkflow/src/TPCInterpolationSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "SpacePoints/SpacePointsCalibConfParam.h"
#include "Framework/ConfigParamRegistry.h"
#include "Framework/ControlService.h"
#include "Framework/DeviceSpec.h"

using namespace o2::framework;
using namespace o2::globaltracking;
Expand All @@ -55,6 +56,9 @@ void TPCInterpolationDPL::init(InitContext& ic)
if (mProcessSeeds && mSources != mSourcesMap) {
LOG(fatal) << "process-seeds option is not compatible with using different track sources for vDrift and map extraction";
}
int lane = ic.services().get<const o2::framework::DeviceSpec>().inputTimesliceId;
int maxLanes = ic.services().get<const o2::framework::DeviceSpec>().maxInputTimeslices;
mInterpolation.setLane(lane, maxLanes);
}

void TPCInterpolationDPL::updateTimeDependentParams(ProcessingContext& pc)
Expand Down Expand Up @@ -136,13 +140,6 @@ void TPCInterpolationDPL::run(ProcessingContext& pc)
mInterpolation.process();
mTimer.Stop();
LOGF(info, "TPC interpolation timing: Cpu: %.3e Real: %.3e s", mTimer.CpuTime(), mTimer.RealTime());
if (SpacePointsCalibConfParam::Instance().writeUnfiltered) {
// these are the residuals and tracks before outlier rejection; they are not used in production
pc.outputs().snapshot(Output{"GLO", "TPCINT_RES", 0}, mInterpolation.getClusterResidualsUnfiltered());
if (mSendTrackData) {
pc.outputs().snapshot(Output{"GLO", "TPCINT_TRK", 0}, mInterpolation.getReferenceTracksUnfiltered());
}
}
pc.outputs().snapshot(Output{"GLO", "UNBINNEDRES", 0}, mInterpolation.getClusterResiduals());
pc.outputs().snapshot(Output{"GLO", "DETINFORES", 0}, mInterpolation.getClusterResidualsDetInfo());
pc.outputs().snapshot(Output{"GLO", "TRKREFS", 0}, mInterpolation.getTrackDataCompact());
Expand All @@ -157,6 +154,7 @@ void TPCInterpolationDPL::run(ProcessingContext& pc)

void TPCInterpolationDPL::endOfStream(EndOfStreamContext& ec)
{
mInterpolation.finalize();
LOGF(info, "TPC residuals extraction total timing: Cpu: %.3e Real: %.3e s in %d slots",
mTimer.CpuTime(), mTimer.RealTime(), mTimer.Counter() - 1);
}
Expand All @@ -183,12 +181,6 @@ DataProcessorSpec getTPCInterpolationSpec(GTrackID::mask_t srcCls, GTrackID::mas
dataRequest->inputs,
true);
o2::tpc::VDriftHelper::requestCCDBInputs(dataRequest->inputs);
if (SpacePointsCalibConfParam::Instance().writeUnfiltered) {
outputs.emplace_back("GLO", "TPCINT_TRK", 0, Lifetime::Timeframe);
if (sendTrackData) {
outputs.emplace_back("GLO", "TPCINT_RES", 0, Lifetime::Timeframe);
}
}
outputs.emplace_back("GLO", "UNBINNEDRES", 0, Lifetime::Timeframe);
outputs.emplace_back("GLO", "DETINFORES", 0, Lifetime::Timeframe);
outputs.emplace_back("GLO", "TRKREFS", 0, Lifetime::Timeframe);
Expand Down
2 changes: 0 additions & 2 deletions Detectors/GlobalTrackingWorkflow/tpcinterpolationworkflow/src/TPCResidualWriterSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ DataProcessorSpec getTPCResidualWriterSpec(bool writeTrackData, bool debugOutput
return MakeRootTreeWriterSpec("tpc-residuals-writer",
"o2residuals_tpc.root",
"residualsTPC",
BranchDefinition<std::vector<TrackData>>{InputSpec{"tracksUnfiltered", "GLO", "TPCINT_TRK", 0}, "tracksUnfiltered", ((writeUnfiltered && writeTrackData) ? 1 : 0)},
BranchDefinition<std::vector<TPCClusterResiduals>>{InputSpec{"residualsUnfiltered", "GLO", "TPCINT_RES", 0}, "residualsUnfiltered", (writeUnfiltered ? 1 : 0)},
BranchDefinition<std::vector<UnbinnedResid>>{InputSpec{"residuals", "GLO", "UNBINNEDRES"}, "residuals"},
BranchDefinition<std::vector<DetInfoResid>>{InputSpec{"detInfo", "GLO", "DETINFORES"}, "detInfo"},
BranchDefinition<std::vector<TrackDataCompact>>{InputSpec{"trackRefs", "GLO", "TRKREFS"}, "trackRefs"},
Expand Down
4 changes: 3 additions & 1 deletion Detectors/TPC/calibration/SpacePoints/include/SpacePoints/SpacePointsCalibConfParam.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ struct SpacePointsCalibConfParam : public o2::conf::ConfigurableParamHelper<Spac

// parameters for outlier rejection
bool skipOutlierFiltering{false}; ///< if set, the outlier filtering will not be applied at all
bool writeUnfiltered{false}; ///< if set, all residuals and track parameters will be aggregated and dumped additionally without outlier rejection
bool writeUnfiltered{false}; ///< if set, tracks failing validation will be kept with filterFlag>0 giving the reason of rejection
bool keepRejectedResiduals{false}; ///< if set, keep rejected residuals setting rejected flag
int nMALong{15}; ///< number of points to be used for moving average (long range)
int nMAShort{3}; ///< number of points to be used for estimation of distance from local line (short range)
float maxRejFrac{.15f}; ///< if the fraction of rejected clusters of a track is higher, the full track is invalidated
Expand All @@ -74,6 +75,7 @@ struct SpacePointsCalibConfParam : public o2::conf::ConfigurableParamHelper<Spac
float maxDevHelixZ = .3f; ///< max deviation in Z for clusters wrt helix fit
int minNumberOfAcceptedResiduals = 30; ///< min number of accepted residuals for
float maxStdDevMA = 25.f; ///< max cluster std. deviation (Y^2 + Z^2) wrt moving average to accept
bool writeValidationData = false; ///< write track validation data for debugging

// settings for voxel residuals extraction
bool isBfieldZero = false; ///< for B=0 we set the radial distortions to zero and don't fit dy vs tgSlp
Expand Down
Loading