Antalya 26.5: Antalya 26.3 forward-port: Token Authentication and Authorization#1936
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.5: Antalya 26.3 forward-port: Token Authentication and Authorization#1936zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1658 from Altinity/feature/antalya-26.3/pr-1430-1596 Antalya 26.3 forward-port: Token Authentication and Authorization # Conflicts: # ci/jobs/scripts/check_style/aspell-ignore/en/aspell-dict.txt # src/Access/IAccessStorage.cpp # src/Access/UsersConfigParser.cpp
aspell-dict.txt and IAccessStorage.cpp: keep both sides (antalya-26.5 words/include plus the PR's additions). UsersConfigParser.cpp: antalya-26.5 refactored parseUserAuthMethod to return an AuthenticationData value (no user parameter) using the per-method 'const auto <x>_config' idiom and the num_authentication_types counter. Adapted the PR's JWT support to this shape: declare jwt_config / has_jwt in the new idiom, add has_jwt to num_authentication_types and to the valid-types error message, and route the JWT branch through auth_data instead of user->authentication_methods. Dropped the PR's trailing 'else' default branch (user is not in scope here and it is unreachable given the count guarantee).
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Introduce token-based authentication and authorization (#1658 by @zvonand).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1658.
Cherry-picked from #1430.
Introduce authentication using access tokens.