fix(schema): fill-width fit + gentler wheel zoom in the full view#51
Merged
Conversation
Two small UX tweaks to the fullscreen schema graph: - Fit-to-width: new pure fitWidthBox() frames the graph so its WIDTH fills the container (viewBox aspect matched to the container → no horizontal letterbox), anchored at the top so a tall graph scrolls/pans down. openSchemaFullscreen opts into it via a fitWidth flag threaded through openGraphFullscreen → attachPanZoom; the initial frame, the Fit button, and double-click all use it. The pipeline graph + inline pane keep fit-whole. - Gentler wheel zoom: a dedicated WHEEL_ZOOM_STEP (1.04, ~4%/notch) for ⌘/Ctrl+ wheel so it isn't jumpy on a trackpad; the +/- buttons keep the 1.2 step. Tests: fitWidthBox (fill-width + aspect-match + unknown-size fallback) in panzoom.test.js; a fitWidth integration assertion in explain-graph.test.js. 935 tests pass; per-file coverage gate green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XmDqY6Bxf5b1fyQE8XwA2u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small UX tweaks to the fullscreen schema graph (follow-up to #47), tested on github.demo.
Changes
fitWidthBox()frames the graph so its width fills the container (viewBox aspect matched to the container, so no horizontal letterboxing), anchored at the top; a tall graph scrolls/pans down.openSchemaFullscreenopts in via afitWidthflag threaded throughopenGraphFullscreen→attachPanZoom; the initial frame, Fit button, and double-click all use it. The pipeline graph and inline pane keep fit-whole.WHEEL_ZOOM_STEP(1.04, ~4%/notch) for ⌘/Ctrl+wheel so it isn't jumpy on a trackpad; the +/− buttons keep the 1.2 step.Tests
fitWidthBox(fill-width + aspect-match + unknown-size fallback) inpanzoom.test.js; afitWidthintegration assertion inexplain-graph.test.js. 935 tests pass; per-file coverage gate green.🤖 Generated with Claude Code
https://claude.ai/code/session_01XmDqY6Bxf5b1fyQE8XwA2u